Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding base_schema_path to the converter #139

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

djarecka
Copy link
Contributor

I'm wondering if this could be accepted as an enhancement to the schemasheets. If yes, I would add to the documentation and do some extra checks.

The idea is that I have some classes that are written in yaml and I would like to add them to the new schema without transferring them first to the schema form. Right now I'm adding this by myself after running schemasheets, but I thought that I might try to slightly generalize it and suggest the addition.

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The title says [wip] but I assume you forgot to remove this, as it looks ready (usually marking as Draft is fine to entail WIP)

@djarecka
Copy link
Contributor Author

I was thinking about adding documentation for this, but I can also add a separate PR with more changes to the documentation

@djarecka djarecka changed the title [wip] adding base_schema_path to the converter adding base_schema_path to the converter Mar 25, 2024
@cmungall cmungall merged commit 649af7e into linkml:main Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants