Skip to content

Conversation

@konard
Copy link
Member

@konard konard commented Sep 13, 2025

Summary

Renamed the AddSkipFirst method to SkipAndAdd as requested in issue #80.

Changes Made

  • Primary target: Renamed AddSkipFirst<T>(this IList<T> list, IList<T> elements, int skip) method at line 173 in IListExtensions.cs to SkipAndAdd
  • Comprehensive updates: Updated all related method names consistently across the codebase:
    • C# files: IListExtensions.cs, ISetExtensions.cs, GenericArrayExtensions.cs, and various Filler classes
    • C++ files: Corresponding header files with same method signatures
  • Method variants updated:
    • AddSkipFirstSkipAndAdd
    • AddSkipFirstAndReturnTrueSkipAndAddAndReturnTrue
    • AddSkipFirstAndReturnConstantSkipAndAddAndReturnConstant

Test Results

  • ✅ All C# tests pass (20 tests completed successfully)
  • ✅ Build completes without errors
  • ✅ No breaking changes to existing functionality

Files Modified

C# Files

  • Platform.Collections/Lists/IListExtensions.cs
  • Platform.Collections/Sets/ISetExtensions.cs
  • Platform.Collections/Arrays/GenericArrayExtensions.cs
  • Platform.Collections/Lists/ListFiller.cs
  • Platform.Collections/Sets/SetFiller.cs
  • Platform.Collections/Arrays/ArrayFiller[TElement].cs
  • Platform.Collections/Arrays/ArrayFiller[TElement, TReturnConstant].cs

C++ Files

  • Platform.Collections/Lists/IListExtensions.h
  • Platform.Collections/Sets/ISetExtensions.h
  • Platform.Collections/Arrays/GenericArrayExtensions.h
  • Platform.Collections/Lists/ListFiller.h
  • Platform.Collections/Sets/SetFiller.h
  • Platform.Collections/Arrays/ArrayFiller[TElement].h
  • Platform.Collections/Arrays/ArrayFiller[TElement, TReturnConstant].h

Resolves #80

🤖 Generated with Claude Code

Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #80
@konard konard self-assigned this Sep 13, 2025
- Renamed all occurrences of AddSkipFirst to SkipAndAdd in IListExtensions.cs (line 173 as specified in issue #80)
- Updated method names consistently in all related files:
  - C# files: Sets, Arrays, ListFiller classes and their extensions
  - C++ files: Corresponding header files with same method signatures
- Applied consistent naming pattern across both C# and C++ implementations
- All tests pass successfully after the rename
- Build completes without errors

Resolves issue #80

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Rename the method into SkipAndAdd Rename AddSkipFirst method to SkipAndAdd Sep 13, 2025
@konard konard marked this pull request as ready for review September 13, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename the method into SkipAndAdd

2 participants