Optimize Vector operations with size-based performance thresholds #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #72
This commit addresses issue #72 by implementing performance-based optimizations for System.Numerics.Vector operations in the BitString class. Key changes: - Added VectorMinThreshold (2 words) and VectorMaxThreshold (7812 words) constants - Implemented ShouldUseVectorOperations() method for intelligent Vector/regular operation selection - Updated all Vector methods (VectorNot, VectorAnd, VectorOr, VectorXor) to use size-based fallback - Updated ParallelVector methods to use the new logic Performance improvements: - Small sizes (< 128 bits): Now use faster regular operations - Large sizes (> 500k bits): Now use faster regular operations - Medium sizes (128 bits - 500k bits): Continue using Vector operations for optimal performance - Up to 27x speedup maintained in the optimal range All existing tests pass, ensuring backward compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #72 by implementing intelligent size-based optimizations for
System.Numerics.Vectoroperations in theBitStringclass.Key Finding
System.Numerics.Vector is NOT universally faster than regular instructions. Performance varies dramatically based on data size:
Implementation
Changes Made
VectorMinThreshold = 2andVectorMaxThreshold = 7812ShouldUseVectorOperations()method for intelligent decision makingVectorNot(),VectorAnd(),VectorOr(),VectorXor()ParallelVectorNot(),ParallelVectorAnd(),ParallelVectorOr(),ParallelVectorXor()Performance Results
Benefits
✅ Improved performance across all data size ranges
✅ Automatic optimization - no API changes required
✅ Backward compatible - all existing tests pass
✅ Predictable behavior - consistent performance characteristics
Test Results
🤖 Generated with Claude Code
Resolves #72