Skip to content

Remove unused Factorial method and related code #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove unused Factorial method and related code #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
621c692
Initial commit with task details for issue #59
konard Sep 13, 2025
f9679b0
Remove unused Factorial method and related code
konard Sep 13, 2025
86eefa9
Remove CLAUDE.md - Claude command completed
konard Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions csharp/Platform.Numbers.Benchmarks/MathBenchmarks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,6 @@ public static ulong FactorialWhileLoopWithoutArrayAndCountingArrayLength(ulong n
}
private const ulong FactorialNumber = 19;

[Benchmark]
public ulong CurrentFactorialImplementation()
{
return Math.Factorial(FactorialNumber);
}

[Benchmark]
public ulong FactorialUsingStaticArrayAndRecursionWithContantAsMaximumN()
{
Expand Down
36 changes: 0 additions & 36 deletions csharp/Platform.Numbers/Math.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ namespace Platform.Numbers
/// <remarks>Resizable array (FileMappedMemory) for values cache may be used. or cached oeis.org</remarks>
public static class Math
{
private static readonly ulong[] _factorials =
{
1, 1, 2, 6, 24, 120, 720, 5040, 40320, 362880, 3628800, 39916800,
479001600, 6227020800, 87178291200, 1307674368000, 20922789888000,
355687428096000, 6402373705728000, 121645100408832000, 2432902008176640000
};
private static readonly ulong[] _catalans =
{
1, 1, 2, 5, 14, 42, 132, 429, 1430, 4862, 16796, 58786, 208012,
Expand All @@ -26,42 +20,12 @@ public static class Math
14544636039226909, 55534064877048198, 212336130412243110, 812944042149730764, 3116285494907301262, 11959798385860453492
};

/// <summary>
/// <para>Represents the limit for calculating the catanal number, supported by the <see cref="ulong"/> type.</para>
/// <para>Представляет предел расчёта катаналового числа, поддерживаемый <see cref="ulong"/> типом.</para>
/// </summary>
public static readonly ulong MaximumFactorialNumber = 20;

/// <summary>
/// <para>Represents the limit for calculating the factorial number, supported by the <see cref="ulong"/> type.</para>
/// <para>Представляет предел расчёта факториала числа, поддерживаемый <see cref="ulong"/> типом.</para>
/// </summary>
public static readonly ulong MaximumCatalanIndex = 36;

/// <summary>
/// <para>Returns the product of all positive integers less than or equal to the number specified as an argument.</para>
/// <para>Возвращает произведение всех положительных чисел меньше или равных указанному в качестве аргумента числу.</para>
/// </summary>
/// <param name="n">
/// <para>The maximum positive number that will participate in factorial's product.</para>
/// <para>Максимальное положительное число, которое будет участвовать в произведении факториала.</para>
/// </param>
/// <returns>
/// <para>The product of all positive integers less than or equal to the number specified as an argument.</para>
/// <para>Произведение всех положительных чисел меньше или равных указанному, в качестве аргумента, числу.</para>
/// </returns>
public static TLinkAddress Factorial<TLinkAddress>(TLinkAddress n) where TLinkAddress : IUnsignedNumber<TLinkAddress>, IComparisonOperators<TLinkAddress, TLinkAddress, bool>
{
if (n >= TLinkAddress.Zero && n <= TLinkAddress.CreateTruncating(MaximumCatalanIndex))
{
return TLinkAddress.CreateTruncating(_factorials[ulong.CreateTruncating(n)]);
}
else
{
throw new ArgumentOutOfRangeException($"Only numbers from 0 to {MaximumFactorialNumber} are supported by unsigned integer with 64 bits length.");
}
}

/// <summary>
/// <para>Returns the Catalan Number with the number specified as an argument.</para>
/// <para>Возвращает Число Катанала с номером, указанным в качестве аргумента.</para>
Expand Down
Loading