Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commenting Setters #38

Merged
merged 49 commits into from
Oct 19, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
d91d1ad
Added comments
qwasd3lol Oct 31, 2021
7305d0e
Update Setter[TResult].cs
qwasd3lol Oct 31, 2021
026d250
Update Setter[TResult, TDecision].cs
qwasd3lol Oct 31, 2021
bf1f3ae
Added comments
qwasd3lol Nov 21, 2021
38212ef
Added comments
qwasd3lol Nov 21, 2021
00e37ea
Added comments
qwasd3lol Nov 21, 2021
41d8ad1
Added comments
qwasd3lol Nov 22, 2021
470cdb8
Update .gitignore
qwasd3lol Nov 22, 2021
e477540
Added comments
qwasd3lol Nov 23, 2021
8387a3e
Update csharp/Platform.Setters/SetterBase.cs
qwasd3lol Nov 23, 2021
a3c6bdc
Comments added
qwasd3lol Nov 23, 2021
863b25a
Merge branch 'qwasd3lol' of https://github.com/linksplatform/Setters …
qwasd3lol Nov 23, 2021
4fa4916
Update Setter[TResult, TDecision].cs
qwasd3lol Nov 23, 2021
0cd5bed
update
qwasd3lol Nov 23, 2021
51e3f90
Update Setter[TResult, TDecision].cs
qwasd3lol Nov 23, 2021
bf9169e
Merge branch 'master' into qwasd3lol
qwasd3lol Nov 23, 2021
d7db23f
Update Setter[TResult, TDecision].cs
qwasd3lol Nov 23, 2021
60b4441
Update SetterBase.cs
qwasd3lol Nov 25, 2021
12faf67
Update csharp/Platform.Setters/Setter[TResult, TDecision].cs
qwasd3lol Nov 27, 2021
a7b8c66
Update csharp/Platform.Setters/Setter[TResult, TDecision].cs
qwasd3lol Nov 27, 2021
cd3a4ce
Update csharp/Platform.Setters/Setter[TResult, TDecision].cs
qwasd3lol Nov 27, 2021
75a00d7
Added comments
qwasd3lol Nov 27, 2021
8d25554
Merge branch 'qwasd3lol' of https://github.com/linksplatform/Setters …
qwasd3lol Nov 27, 2021
95704cb
Update Setter[TResult].cs
qwasd3lol Nov 27, 2021
d246dd9
Update Setter[TResult, TDecision].cs
qwasd3lol Nov 27, 2021
19e1a2e
Update Setter[TResult].cs
qwasd3lol Nov 27, 2021
f5cfb3b
Update .gitignore
qwasd3lol Dec 20, 2021
788318e
Update csharp/Platform.Setters/SetterBase.cs
qwasd3lol Dec 20, 2021
9c01d32
Update csharp/Platform.Setters/Setter[TResult, TDecision].cs
qwasd3lol Dec 20, 2021
b4d0fc4
Removed extra comments
qwasd3lol Dec 20, 2021
02e20b1
Update .gitignore
qwasd3lol Dec 20, 2021
b4e5755
Added comments
qwasd3lol Jan 9, 2022
c100650
Update Setter[TResult, TDecision].cs
qwasd3lol Jan 12, 2022
042b81d
Merge branch 'master' into qwasd3lol
qwasd3lol Jan 12, 2022
4741355
Update Setter[TResult, TDecision].cs
qwasd3lol Jan 12, 2022
5b5cf00
update
qwasd3lol Jan 12, 2022
8658f0f
Update csharp/Platform.Setters/Setter[TResult, TDecision].cs
qwasd3lol Jan 14, 2022
f72a42d
Added comments
qwasd3lol Jan 18, 2022
cbc8708
Merge branch 'qwasd3lol' of https://github.com/linksplatform/Setters …
qwasd3lol Jan 18, 2022
553725e
Update Setter[TResult, TDecision].cs
qwasd3lol Jan 18, 2022
7462dc0
added comments
qwasd3lol Feb 7, 2022
8accc87
Update Setter[TResult, TDecision].cs
qwasd3lol Feb 21, 2022
3afc63b
ds store removed and comments added
qwasd3lol Mar 3, 2022
3ef92d8
update
qwasd3lol Mar 3, 2022
80d961e
Added comments
qwasd3lol Apr 7, 2022
6d5ea66
added comments
qwasd3lol May 3, 2022
8212c44
removed pragmas
qwasd3lol May 3, 2022
6cbe27b
Update Setter[TResult, TDecision].cs
qwasd3lol Jul 28, 2022
635fc9c
Update csharp/Platform.Setters/Setter[TResult, TDecision].cs
Konard Oct 19, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions csharp/Platform.Setters/SetterBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ public abstract class SetterBase<TResult> : ISetter<TResult>

/// <summary>
/// <para>Initializes a new instance of the <see cref="SetterBase"/> class.</para>
/// <para>Инициализирует новый экземпляр класса <see cref="SetterBase{TResult}"/>.</para>
/// <para>Инициализирует новый экземпляр класса <see cref="SetterBase"/>.</para>
/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected SetterBase() { }

/// <summary>
/// <para>Initializes a new instance of the <see cref="SetterBase{TResult}"/> class using the <paramref name="defaultValue"/> as the default result.</para>
/// <para>Инициализирует новый экземпляр класса <see cref="SetterBase{TResult}"/>, используя <paramref name="defaultValue"/> в качестве результата.</para>
/// <para>Initializes a new instance of the <see cref="SetterBase"/> class using the <paramref name="defaultValue"/> as the default result.</para>
/// <para>Инициализирует новый экземпляр класса <see cref="SetterBase"/>, используя <paramref name="defaultValue"/> в качестве результата.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <para>Инициализирует новый экземпляр класса <see cref="SetterBase"/>, используя <paramref name="defaultValue"/> в качестве результата.</para>
/// <para>Инициализирует новый экземпляр класса <see cref="SetterBase"/>, используя <paramref name="defaultValue"/> в качестве результата по умолчанию.</para>

/// </summary>
/// <param name="defaultValue">
/// <para>A default result value.</para>
Expand Down
6 changes: 3 additions & 3 deletions csharp/Platform.Setters/Setter[TResult, TDecision].cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ namespace Platform.Setters
/// <para>Тип результирующего значения.</para>
/// </typeparam>
/// <typeparam name="TDecision">
/// <para>The type of a value which will be used to make the decision.</para>
/// <para>Тип значения на основе которого будет приниматься решение.</para>
/// <para>The type of a true and false value.</para>
qwasd3lol marked this conversation as resolved.
Show resolved Hide resolved
/// <para>Тип значений "истина" и "ложь".</para>
qwasd3lol marked this conversation as resolved.
Show resolved Hide resolved
/// </typeparam>
Konard marked this conversation as resolved.
Show resolved Hide resolved
public class Setter<TResult, TDecision> : SetterBase<TResult>
{
Expand Down Expand Up @@ -55,7 +55,7 @@ public Setter(TDecision trueValue, TDecision falseValue, TResult defaultValue)
public Setter(TDecision trueValue, TDecision falseValue) : this(trueValue, falseValue, default) { }

/// <summary>
/// <para>Initializes a new instance of the <see cref="Setter{TResult, TDecision}"/> class with the <paramref name="defaultValue"/>.</para>
/// <para>Initializes a new instance of the <see cref="Setter{TResult, TDecision}"/> class with the <paramref name="defaultValue"/> as result.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget about article

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need an article here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a result

/// <para>Инициализирует новый экземпляр класса <see cref="Setter{TResult, TDecision}"/>, со значением <paramref name="defaultValue"/> в качестве результата по умолчанию.</para>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <para>Инициализирует новый экземпляр класса <see cref="Setter{TResult, TDecision}"/>, со значением <paramref name="defaultValue"/> в качестве результата по умолчанию.</para>
/// <para>Инициализирует новый экземпляр класса <see cref="Setter{TResult, TDecision}"/>, используя значение <paramref name="defaultValue"/> в качестве результата по умолчанию.</para>

/// </summary>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add param tag the argument too.

Expand Down