Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Edit account page #770

Closed
skyserpent opened this issue Sep 5, 2014 · 11 comments
Closed

Suggestion: Edit account page #770

skyserpent opened this issue Sep 5, 2014 · 11 comments
Milestone

Comments

@skyserpent
Copy link

There should be an edit account page for the boilerplate to make it a better boilerplate. Sort of like how Hackathon-Starter has it.

@pratik60
Copy link
Member

pratik60 commented Sep 6, 2014

@skyserpent - This is actually very easy to set up. Something we have done internally for our app which is slated for a public release soon.

The request makes sense (view user profile, and edit user profile). Along with that, I would actually like to extend the user model with a profile picture as a part of it, and in the process we extend the core user package itself.

@fyockm @liorkesos - I could send in a PR for this in the next few days Would it be something you'd be keen to merge? User profile picture, would mean a dependency on the mean upload in the core itself.

@liorkesos
Copy link
Member

+1
On Sep 6, 2014 10:24 AM, "Pratik Bothra" notifications@github.com wrote:

@skyserpent https://github.com/skyserpent - This is actually very easy
to set up. Something we have done internally for our app which is slated
for a public release soon.

The request makes sense (view user profile, and edit user profile). Along
with that, I would actually like to extend the user model with a profile
picture as a part of it, and in the process we extend the core user package
itself.

@fyockm https://github.com/fyockm @liorkesos
https://github.com/liorkesos - I could send in a PR for this in the
next few days Would it be something you'd be keen to merge? User profile
picture, would mean a dependency on the mean upload in the core itself.


Reply to this email directly or view it on GitHub
#770 (comment).

@liorkesos
Copy link
Member

Although I think we can have a default profile pic and not require upload
as a dependency.
On Sep 6, 2014 10:53 AM, "Lior Kesos" lior@linnovate.net wrote:

+1
On Sep 6, 2014 10:24 AM, "Pratik Bothra" notifications@github.com wrote:

@skyserpent https://github.com/skyserpent - This is actually very easy
to set up. Something we have done internally for our app which is slated
for a public release soon.

The request makes sense (view user profile, and edit user profile). Along
with that, I would actually like to extend the user model with a profile
picture as a part of it, and in the process we extend the core user package
itself.

@fyockm https://github.com/fyockm @liorkesos
https://github.com/liorkesos - I could send in a PR for this in the
next few days Would it be something you'd be keen to merge? User profile
picture, would mean a dependency on the mean upload in the core itself.


Reply to this email directly or view it on GitHub
#770 (comment).

@liorkesos
Copy link
Member

pratik - I'd be glad to merge this if you send a PR

@pratik60
Copy link
Member

@lior - I will send it by Wednesday evening for sure.

On Mon, Sep 15, 2014 at 7:19 PM, Lior Kesos notifications@github.com
wrote:

pratik - I'd be glad to merge this if you send a PR


Reply to this email directly or view it on GitHub
#770 (comment).

@scrock1987
Copy link

@liorkesos I can provide with the PR for Edit user profile If you'd like.

@pratik60
Copy link
Member

@scrock1987 / @brownman - Feel free to complete/extend/overwrite this in altogetherness....

https://github.com/pratik60/mean-user-package

@liorkesos
Copy link
Member

Sauarbh,
That would be awesome.
Lior

On Wed, Jan 28, 2015 at 1:09 PM, Saurabh Chawla notifications@github.com
wrote:

@liorkesos https://github.com/liorkesos I can provide with the PR for
Edit user profile If you'd like.


Reply to this email directly or view it on GitHub
#770 (comment).

Lior Kesos - http://www.linnovate.net
Linnovate - Community Infrastructure Care
mail: lior@linnovate.net
office: +972 722500881
cell: +972 524305252
skype: liorkesos

@VikramTiwari
Copy link
Member

PR needed. @pratik60 @scrock1987

@VikramTiwari
Copy link
Member

I think this is a good feature. If anyone wants to work on this, I would be happy to merge.

@VikramTiwari VikramTiwari added this to the v0.7.1 milestone Sep 17, 2016
@timelf123
Copy link
Contributor

Before we had forked the user package, we created a userprofile package to store this info in our project. In hindsight, this is much better stored on the user model itself so we dont have to call populate('userprofile')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants