Feature angular material #1649
Merged
Feature angular material #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace jshint task with standard task in gulp dev formatted all files wrt standard linter fixed lint warnings regarding path and split vars fixed lint warnings around error handling fixed other misc lint warnings
fixed all warnings for standard linter removed jshint tasks removed jshintrc and ignore files removed from package.json
removed bootstrap fixed layout issues fixed header
| resolve: { | ||
| modulesDirectories: ['bower_components', 'node_modules'] | ||
| } | ||
| } |
gulp running sass, less before webpack removed all extra css which is not required now
This was referenced Sep 3, 2016
| var devCompiler = webpack(myDevConfig); | ||
| gulp.task('webpack:build-dev', function(callback) { | ||
| var devCompiler = webpack(myDevConfig) | ||
| gulp.task('webpack:build-dev', ['sass', 'less'], function (callback) { |
There was a problem hiding this comment.
Tried this fix in our project, on a fresh install it prevents webpack from building without having the processed .css files, but it seems to trigger the watch over and over as each .scss file is processed. It's functional, but it creates difficult to unusable output and extends the time for the server to be ready significantly.
There was a problem hiding this comment.
I didn't give it a good look earlier. Could you try and fix issue in current master and raise a PR?
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WRT: #1648