Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port configuration for passport in production environment. #270

Closed
wants to merge 1 commit into from
Closed

Port configuration for passport in production environment. #270

wants to merge 1 commit into from

Conversation

bbaaxx
Copy link

@bbaaxx bbaaxx commented Feb 8, 2014

Replaced the callbackUrl value for all passport providers in config/env/production.js to insert the value of process.env.PORT to the string.

@thehashrocket
Copy link

I believe in production you wouldn't pass localhost as your callback url. it'd be the domain your currently hosted at, for example: "http://www.example.com/auth/twitter/callback"

See, for example, this stackoverflow post:
http://stackoverflow.com/questions/20304583/node-js-github-oauth-callback-using-dynamic-host

@bbaaxx bbaaxx closed this Feb 9, 2014
@bbaaxx
Copy link
Author

bbaaxx commented Feb 9, 2014

Ha! you are totally right, thanks for pointing that out.

@bbaaxx bbaaxx deleted the callback-urls-in-production branch February 9, 2014 23:26
@thehashrocket
Copy link

Once every blood moon in right. Obviously blood mind don't come along every
day. I shall rejoice in this moment! ;-)
On Feb 9, 2014 4:26 PM, "Eduardo M" notifications@github.com wrote:

Ha! you are totally right, thanks for pointing that out.

Reply to this email directly or view it on GitHubhttps://github.com//pull/270#issuecomment-34591132
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants