Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default resource config #1726

Merged
merged 4 commits into from
Sep 24, 2024
Merged

fix: default resource config #1726

merged 4 commits into from
Sep 24, 2024

Conversation

srodenhuis
Copy link
Contributor

This PR:

  • configures resource defaults for a number of apps. Design principle is NOT to specify resources in any .gotmpl, but instead define them in the otomi-values and add the defaults to the defaults.yaml
  • optimizes resources.request for a number of apps to prevent CPUThrottlingHigh alerts

Checklist

  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

helmfile.d/snippets/defaults.yaml Outdated Show resolved Hide resolved
helmfile.d/snippets/defaults.yaml Show resolved Hide resolved
@merll
Copy link
Contributor

merll commented Sep 24, 2024

I am getting this error

2024-09-24T10:08:55.670Z otomi:cmd:validate-values:validateValues:error {
  keyword: 'additionalProperties',
  dataPath: '/apps/harbor/resources',
  schemaPath: '#/properties/apps/properties/harbor/properties/resources/additionalProperties',
  params: { additionalProperty: 'registry-controller' },
  message: 'must NOT have additional properties'
}

The updated values schema is correct, but existing values are not being migrated. See my change suggestion below.

values-changes.yaml Outdated Show resolved Hide resolved
@srodenhuis srodenhuis merged commit 5396b10 into main Sep 24, 2024
5 checks passed
@srodenhuis srodenhuis deleted the sr-fix-resources branch September 24, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants