Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: knative domain-template #1738

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: knative domain-template #1738

merged 1 commit into from
Sep 30, 2024

Conversation

srodenhuis
Copy link
Contributor

Fix for APL-238. The KnativeServing CR needed updating after upgrade.

j-zimnowoda
j-zimnowoda approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding!

@j-zimnowoda j-zimnowoda merged commit 5145a05 into main Sep 30, 2024
5 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-238-fix-domain-template branch September 30, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

@ferruhcihan ferruhcihan Awaiting requested review from ferruhcihan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srodenhuis @j-zimnowoda