Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default cpu requests #1741

Merged
merged 6 commits into from
Oct 1, 2024
Merged

fix: default cpu requests #1741

merged 6 commits into from
Oct 1, 2024

Conversation

srodenhuis
Copy link
Contributor

@srodenhuis srodenhuis commented Sep 30, 2024 •
edited
Loading

  • update default cpu requests
  • make resources for team alertmanager and grafana configurable (part of alertmanager and grafana apps)
  • add resourse default for tekton-triggers and tekton-pipelines
  • remove unused provider config
  • remove redis-shared release
  • remove oauth2-proxy-redis release (redis is part of oauth2-proxy release)
  • remove redis chart (not used)
  • fix oauth2 replica's (now set to 2)

Checklist

  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@srodenhuis srodenhuis marked this pull request as draft October 1, 2024 06:58
@srodenhuis srodenhuis marked this pull request as ready for review October 1, 2024 07:33
@srodenhuis srodenhuis requested a review from CasLubbers October 1, 2024 07:34
CasLubbers
CasLubbers approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests work ✅

@srodenhuis srodenhuis merged commit 2cd44b4 into main Oct 1, 2024
5 checks passed
@srodenhuis srodenhuis deleted the sr-fix-cpu-req branch October 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasLubbers CasLubbers CasLubbers approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda

@Ani1357 Ani1357 Awaiting requested review from Ani1357

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srodenhuis @CasLubbers