Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apl-248 github actions update to support valid dns by default #1748

Merged
merged 53 commits into from
Oct 14, 2024

Conversation

Ani1357
Copy link
Contributor

@Ani1357 Ani1357 commented Oct 7, 2024

This PR updates our integration github actions to use valid domain names be default.
Key changes in this PR:

  • removed Scaleway config
    • deleted .github/workflows/integration-on-schedule-dns-no-admin-pass.yml
  • removed Azure config
  • Removed nip.io configs
    • removed .github/workflows/integration-on-schedule-dns-no-admin-pass.yml
    • removed .github/workflows/integration-on-schedule-dns.yml
    • updated nightly integration tests for full, upgrade, minimal, minimal-with-teams and minimal-no-admin-pass
  • Set default generate_password: yes
  • Set default kms: age
  • Set default certificate: letsencrypt_production

Testing:

  • From Deploy Otomi github action tab click Run Workflow.
  • In Use workflow from select Branch: APL-248_gha-update.
  • Select your domain and click Deploy.
  • After the deployment finishes you can download the kubeconfig and monitor the argocd applications status until they are ready.
  • When ready you can access your cluster with the randomly generated password.

versions.yaml Outdated Show resolved Hide resolved
@Ani1357 Ani1357 requested a review from j-zimnowoda October 10, 2024 08:03
@Ani1357 Ani1357 enabled auto-merge (squash) October 10, 2024 08:04
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with my domain. Works well

Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is possible it would be a nice change.

.github/workflows/integration.yml Outdated Show resolved Hide resolved
@Ani1357 Ani1357 merged commit 73ed921 into main Oct 14, 2024
5 checks passed
@Ani1357 Ani1357 deleted the APL-248_gha-update branch October 14, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants