Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ispreinstalled flag #1760

Merged
merged 13 commits into from
Oct 23, 2024
Merged

feat: ispreinstalled flag #1760

merged 13 commits into from
Oct 23, 2024

Conversation

ElderMatt
Copy link
Contributor

@ElderMatt ElderMatt commented Oct 14, 2024

This PR adds isPreInstalled flag for the installer.
See: APL-134

Also removed Minio dependency for everything

.github/workflows/integration.yml Show resolved Hide resolved
.github/workflows/integration.yml Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
@srodenhuis srodenhuis self-requested a review October 15, 2024 09:57
Copy link
Contributor

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@srodenhuis srodenhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) October 23, 2024 09:29
@j-zimnowoda j-zimnowoda merged commit e498b48 into main Oct 23, 2024
5 checks passed
@j-zimnowoda j-zimnowoda deleted the apl-134 branch October 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants