feat: adding KnativeServing CR ORCS support #2260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-zimnowoda
reviewed
Jun 20, 2025
j-zimnowoda
reviewed
Jun 20, 2025
j-zimnowoda
previously requested changes
Jun 20, 2025
|
Hardcoded the version in the gotmpl. Also there is already a version in there which needs to be updated. So I think its fine. |
merll
approved these changes
Jul 9, 2025
CasLubbers
approved these changes
Jul 14, 2025
j-zimnowoda
added a commit
that referenced
this pull request
Jul 16, 2025
This reverts commit 9871159.
merll
pushed a commit
that referenced
this pull request
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
APL-887
This PR configures the KnativeServing CR to use images from ORCS when useORCS is set to true.
Knative documentation
🔍 Reviewer Notes
🧹 Checklist