-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Ansible Playbook for Integration Test; Wait for Volume Active on Creation #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
ykim-akamai,
yec-akamai and
lgarber-akamai
and removed request for
a team
April 3, 2024 01:20
zliang-akamai
force-pushed
the
zhiwei/fix-e2e
branch
from
April 3, 2024 03:30
151ee0d
to
1ede881
Compare
zliang-akamai
changed the title
Fix the Ansible Playbook for Integration Test
Fix the Ansible Playbook for Integration Test; Wait for Volume after Creation
Apr 3, 2024
zliang-akamai
changed the title
Fix the Ansible Playbook for Integration Test; Wait for Volume after Creation
Fix the Ansible Playbook for Integration Test; Wait for Volume Active on Creation
Apr 3, 2024
lgarber-akamai
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well in my local testing, nice work!
ykim-akamai
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
quick-test
toint-test
.no_log: true
to prevent tokens appearing in the logs.root
tolinodedx
user on the remote host.Create
function.✔️ How to Test
Sometimes you may see an error caused by the race condition that when the Volume is being deleted during the test cleanup, the volume is still in busy status and will return you a 400 error. You can remove
no_log: true
in taskRun the test suite
to see the error message when the error occurs.I think this can be considered as a bug rather than testing workflow issue,
so it may be fixed in another PR.It's too annoying so I just fix it anyway, by waiting for the volume to be active in the create function.