Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Ansible Playbook for Integration Test; Wait for Volume Active on Creation #145

Merged
merged 9 commits into from
Apr 3, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Apr 3, 2024

📝 Description

  • Rename quick-test to int-test.
  • Add no_log: true to prevent tokens appearing in the logs.
  • Replace Alpine image with Ubuntu 23.10 to enable cloud-init functionalities.
  • Minimize size of the Linode instance used for testing.
  • Switch from root to linodedx user on the remote host.
  • Various fixes to make it works.
  • Wait for the volume to be active in the Create function.

✔️ How to Test

make int-test

Sometimes you may see an error caused by the race condition that when the Volume is being deleted during the test cleanup, the volume is still in busy status and will return you a 400 error. You can remove no_log: true in task Run the test suite to see the error message when the error occurs.

I think this can be considered as a bug rather than testing workflow issue, so it may be fixed in another PR. It's too annoying so I just fix it anyway, by waiting for the volume to be active in the create function.

@zliang-akamai zliang-akamai requested a review from a team as a code owner April 3, 2024 01:20
@zliang-akamai zliang-akamai requested review from ykim-akamai, yec-akamai and lgarber-akamai and removed request for a team April 3, 2024 01:20
@zliang-akamai zliang-akamai changed the title Fix the Ansible Playbook for Integration Test Fix the Ansible Playbook for Integration Test; Wait for Volume after Creation Apr 3, 2024
@zliang-akamai zliang-akamai changed the title Fix the Ansible Playbook for Integration Test; Wait for Volume after Creation Fix the Ansible Playbook for Integration Test; Wait for Volume Active on Creation Apr 3, 2024
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my local testing, nice work!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this

@zliang-akamai zliang-akamai merged commit 2d616fb into linode:main Apr 3, 2024
1 check passed
@zliang-akamai zliang-akamai deleted the zhiwei/fix-e2e branch April 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants