-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose region capabilities enum #507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
added
the
improvement
for improvements in existing functionality in the changelog.
label
May 14, 2024
yec-akamai
requested review from
jriddle-linode and
ykim-akamai
and removed request for
a team
May 14, 2024 14:58
yec-akamai
changed the title
Add region capabilities enum
Expose region capabilities enum
May 14, 2024
lgarber-akamai
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
jriddle-linode
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
renovate bot
referenced
this pull request
in anza-labs/lke-operator
May 23, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/linode/linodego](https://togithub.com/linode/linodego) | `v1.33.1` -> `v1.34.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2flinode%2flinodego/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2flinode%2flinodego/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2flinode%2flinodego/v1.33.1/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2flinode%2flinodego/v1.33.1/v1.34.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>linode/linodego (github.com/linode/linodego)</summary> ### [`v1.34.0`](https://togithub.com/linode/linodego/releases/tag/v1.34.0) [Compare Source](https://togithub.com/linode/linodego/compare/v1.33.1...v1.34.0) #### What's Changed #####⚠️ Breaking Change - \[BREAKING] Add support for LKE Control Plane ACL by [@​lgarber-akamai](https://togithub.com/lgarber-akamai) in [https://github.com/linode/linodego/pull/495](https://togithub.com/linode/linodego/pull/495) ##### 🐛 Bug Fixes - Prevent unexpected warning from Resty when calling `Client.SetDebug(false)` by [@​lgarber-akamai](https://togithub.com/lgarber-akamai) in [https://github.com/linode/linodego/pull/508](https://togithub.com/linode/linodego/pull/508) ##### 💡 Improvements - Mask the value of the Authorization header if debug is enabled by [@​rosskirkpat](https://togithub.com/rosskirkpat) in [https://github.com/linode/linodego/pull/501](https://togithub.com/linode/linodego/pull/501) - Expose region capabilities enum by [@​yec-akamai](https://togithub.com/yec-akamai) in [https://github.com/linode/linodego/pull/507](https://togithub.com/linode/linodego/pull/507) ##### ⚙️ Repo/CI Improvements - replace test execution handler with conditional by [@​ykim-1](https://togithub.com/ykim-1) in [https://github.com/linode/linodego/pull/502](https://togithub.com/linode/linodego/pull/502) ##### 📦 Dependency Updates - bump golang.org/x/net from 0.24.0 to 0.25.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/linode/linodego/pull/500](https://togithub.com/linode/linodego/pull/500) - bump github.com/go-resty/resty/v2 from 2.12.0 to 2.13.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/linode/linodego/pull/505](https://togithub.com/linode/linodego/pull/505) - bump golangci/golangci-lint-action from 5 to 6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/linode/linodego/pull/506](https://togithub.com/linode/linodego/pull/506) #### New Contributors - [@​rosskirkpat](https://togithub.com/rosskirkpat) made their first contribution in [https://github.com/linode/linodego/pull/501](https://togithub.com/linode/linodego/pull/501) **Full Changelog**: linode/linodego@v1.33.1...v1.34.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anza-labs/lke-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImFyZWEvZGVwZW5kZW5jeSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add a list of enum for region capabilities. To avoid high-impact breaking change, we only build them into strings instead of a custom type.