fix: [UIE-8338] dbaas IP validation should display updated error mess…

…age that includes IPV6
linode · Dec 12, 2024 · 152be78 · 152be78
1 parent 15992df
commit 152be78
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx b/packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx
@@ -51,6 +51,10 @@ import type { APIError } from '@linode/api-v4/lib/types';
 import type { PlanSelectionWithDatabaseType } from 'src/features/components/PlansPanel/types';
 import type { DatabaseCreateValues } from 'src/features/Databases/DatabaseCreate/DatabaseClusterData';
 import type { ExtendedIP } from 'src/utilities/ipUtils';
+import {
+  ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT,
+  ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT_LEGACY,
+} from '../constants';
 
 const DatabaseCreate = () => {
   const history = useHistory();
@@ -97,7 +101,9 @@ const DatabaseCreate = () => {
   const handleIPValidation = () => {
     const validatedIps = validateIPs(values.allow_list, {
       allowEmptyAddress: true,
-      errorMessage: 'Must be a valid IPv4 address',
+      errorMessage: isDatabasesV2GA
+        ? ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT
+        : ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT_LEGACY,
     });
 
     if (validatedIps.some((ip) => ip.error)) {

diff --git a/packages/manager/src/features/Databases/DatabaseDetail/AddAccessControlDrawer.tsx b/packages/manager/src/features/Databases/DatabaseDetail/AddAccessControlDrawer.tsx
@@ -10,6 +10,8 @@ import { MultipleIPInput } from 'src/components/MultipleIPInput/MultipleIPInput'
 import {
   ACCESS_CONTROLS_DRAWER_TEXT,
   ACCESS_CONTROLS_DRAWER_TEXT_LEGACY,
+  ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT,
+  ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT_LEGACY,
   LEARN_MORE_LINK,
   LEARN_MORE_LINK_LEGACY,
 } from 'src/features/Databases/constants';
@@ -123,7 +125,9 @@ const AddAccessControlDrawer = (props: CombinedProps) => {
   const onValidate = ({ _allowList }: Values) => {
     const validatedIPs = validateIPs(_allowList, {
       allowEmptyAddress: false,
-      errorMessage: 'Must be a valid IPv4 address.',
+      errorMessage: isDefaultDB
+        ? ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT
+        : ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT_LEGACY,
     });
 
     setValues({ _allowList: validatedIPs });

diff --git a/packages/manager/src/features/Databases/constants.ts b/packages/manager/src/features/Databases/constants.ts
@@ -11,6 +11,12 @@ export const ACCESS_CONTROLS_IN_SETTINGS_TEXT =
 export const ACCESS_CONTROLS_IN_SETTINGS_TEXT_LEGACY =
   'Add or remove IPv4 addresses or ranges that should be authorized to access your cluster.';
 
+export const ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT =
+  'Must be a valid IPv6 or IPv4 address.';
+
+export const ACCESS_CONTROLS_IP_VALIDATION_ERROR_TEXT_LEGACY =
+  'Must be a valid IPv4 address.';
+
 export const SUSPEND_CLUSTER_TEXT = `Suspend the cluster if you don't use it temporarily to prevent being billed for it.`;
 
 export const RESET_ROOT_PASSWORD_TEXT =