Skip to content

Commit

Permalink
change: Update PULL_REQUEST_TEMPLATE (Part 3) (#11325)
Browse files Browse the repository at this point in the history
* Address feedback from cafe

* Added changeset: Further improvements to PR template author checklist sections
  • Loading branch information
mjac0bs authored Nov 26, 2024
1 parent 8a6d1ca commit 640d7a6
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 14 deletions.
33 changes: 19 additions & 14 deletions docs/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,23 @@ Please specify a release date (and environment, if applicable) to guarantee time
- [ ] ...
- [ ] ...

## As an Author, I have considered 🤔

- 👀 Doing a self review
- ❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md)
- 🤏 Splitting feature into small PRs
- ➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset)
- 🧪 Providing/improving test coverage
- 🔐 Removing all sensitive information from the code and PR description
- 🚩 Using a feature flag to protect the release
- 👣 Providing comprehensive reproduction steps
- 📑 Providing or updating our documentation
- 🕛 Scheduling a pair reviewing session
- 📱 Providing mobile support
- ♿ Providing accessibility support
<details>
<summary> Author Checklists </summary>

## As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our [contribution guidelines](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md)
🤏 Splitting feature into small PRs
➕ Adding a [changeset](https://github.com/linode/manager/blob/develop/docs/CONTRIBUTING.md#writing-a-changeset)
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

<br/>

Expand All @@ -73,6 +76,8 @@ Please specify a release date (and environment, if applicable) to guarantee time
- [ ] TypeScript compilation succeeded without errors
- [ ] Code passes all linting rules

</details>

---

## Commit message and pull request title format standards
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Further improvements to PR template author checklist sections ([#11325](https://github.com/linode/manager/pull/11325))

0 comments on commit 640d7a6

Please sign in to comment.