feat: [M3-7487] - Add AGLB Endpoint Health #10008

bnussman-akamai · 2023-12-19T17:48:45Z

Description 📝

Adds Endpoint Health information to AGLB

Preview 📷

Before	After

How to test 🧪

Prerequisites

Use the dev environment
Login to the dev-test-aglb account

Verification steps

Verify that you see health data in all of the places shown in the Preview section

As an Author I have considered 🤔

github-actions · 2024-01-11T01:05:20Z

Coverage Report: ✅
Base Coverage: 79.83%
Current Coverage: 79.83%

abailly-akamai

Looks great - approving pending minor fixes

also, more of a UX question, is it worth showing the status icon at all in this case?

abailly-akamai · 2024-01-16T14:23:46Z

packages/api-v4/.changeset/pr-10008-added-1704919102710.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Added
+---


Just to confirm, this isn't an upcoming feature anymore, is it?

I'm going to keep considering it an upcoming feature until it's in public beta. We're probably a few weeks away from that

I'm going to keep considering it an upcoming feature until it's in public beta.

In that case, should this changeset entry be under Upcoming Features rather than Added?

I think I wen't with added because api-v4 has no way to to "gate" features. Once the code is released, it's "added" to the package

Should it still be Upcoming Features?

Once the code is released, it's "added" to the package

Yeah, that's fair. I was thinking we'd been putting other AGLB api-v4 work under Upcoming, so suggested it for consistency, but I might be misremembering.

Yeah, I'm not sure. Maybe api-v4 shouldn't have an Upcoming Features? I'll add a cafe item

abailly-akamai · 2024-01-16T14:40:44Z

...src/features/LoadBalancers/LoadBalancerDetail/ServiceTargets/ServiceTargetEndpointHealth.tsx

+
+  if (!health) {
+    return <EndpointHealth down={0} up={0} />;
+  }


What could health being undefined mean? Is there anything relevant we'd want to display to the user?

It shouldn't really happen because the loading and error cases are checked before this. This was mostly just to satisfy typescript.

abailly-akamai · 2024-01-16T14:42:37Z

packages/manager/src/features/LoadBalancers/LoadBalancerLanding/LoadBalancerRow.tsx

@@ -9,6 +9,7 @@ import { TableRow } from 'src/components/TableRow';
 import { Typography } from 'src/components/Typography';
 import { IPAddress } from 'src/features/Linodes/LinodesLanding/IPAddress';

+import { LoadBalancerEndpontHeath } from '../LoadBalancerDetail/LoadBalancerEndpointHealth';


Got two typos on your export LoadBalancerEndpontHeath > LoadBalancerEndpointHealth

Fixed in 36ee5b8, good catch!

…alth`

mjac0bs

Endpoints are visible:
✅ on the Load Balancer Landing page
✅ on the Load Balancer details Summary tab
✅ in the Configurations tab
✅ in the Service Targets table

Edit:

also, more of a UX question, is it worth showing the status icon at all in this case?

I would also be in favor of not showing the status in this case.

There are some small discrepancies in loading and error state:

For the details page Summary tab, we get a tiny, little loading bar. 🥺
For the Configurations endpoints, when there's an error (blocked network request), we still see the "Endpoints:" text but no data, whereas the other endpoint locations surface an error. Can we make the behavior consistent?

Configurations:

Service Targets:

Details > Summary:

Landing:

mjac0bs · 2024-01-16T18:03:03Z

packages/api-v4/.changeset/pr-10008-added-1704919102710.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Added
+---


I'm going to keep considering it an upcoming feature until it's in public beta.

In that case, should this changeset entry be under Upcoming Features rather than Added?

packages/manager/.changeset/pr-10008-upcoming-features-1704919046550.md

mjac0bs · 2024-01-16T18:06:06Z

packages/manager/src/features/LoadBalancers/LoadBalancerDetail/EndpointHealth.test.tsx

+    expect(upStatusIcon).toHaveStyle({ backgroundColor: '#17cf73' });
+    expect(downStatusIcon).toHaveStyle({ backgroundColor: '#ca0813' });


bnussman-akamai · 2024-01-16T19:25:59Z

also, more of a UX question, is it worth showing the status icon at all in this case?

I would also be in favor of not showing the status in this case.

I think I'm going to show endpoint status at all times because it's often inside a table and I don't think we need to add the complexity of conditionally hiding it.

mjac0bs

because it's often inside a table and I don't think we need to add the complexity of conditionally hiding it.

As long as we don't receive user feedback that it's a reason for visual overwhelm in the table or is somehow confusing to users, I think keeping it is fine.

Thanks for the loading and error state updates - confirmed we no longer see a tiny loader on Summary and the endpoints on Configurations surface an error. ✅

bnussman-akamai · 2024-01-16T20:03:29Z

Definitely will reevaluate the error states if they happen often or if we get feedback about them!

bnussman added 3 commits December 19, 2023 11:51

add load balancer endpoint health api call and query

0b3c3ba

and mocks and inital ui

3f07b87

add health to summary tab and add unit test

eccb6a5

bnussman-akamai added Work in Progress ACLB Relating to the Akamai Cloud Load Balancer labels Dec 19, 2023

bnussman-akamai self-assigned this Dec 19, 2023

bnussman added 5 commits December 19, 2023 13:36

add endpoint health to configurations

6cd1841

add service target endpoint health

7771dc5

add test and improve some comments

f1e64aa

add unit testing

ab17b40

add more testing and comments

49f929a

bnussman-akamai added Blocked Waiting on other work to be done before this and removed Work in Progress labels Dec 21, 2023

Merge branch 'develop' into M3-7487-add-aglb-endpoint-health

0693e98

bnussman-akamai removed the Blocked Waiting on other work to be done before this label Jan 10, 2024

bnussman added 3 commits January 10, 2024 15:36

Merge branch 'develop' into M3-7487-add-aglb-endpoint-health

82fc104

Added changeset: AGLB endpoint health endpoints

15f40ef

add changeset

4c4f692

bnussman-akamai added the Ready for Review label Jan 10, 2024

bnussman-akamai marked this pull request as ready for review January 10, 2024 20:42

bnussman-akamai requested a review from a team as a code owner January 10, 2024 20:42

bnussman-akamai requested review from carrillo-erik and abailly-akamai and removed request for a team January 10, 2024 20:42

Merge branch 'develop' into M3-7487-add-aglb-endpoint-health

d53edeb

bnussman-akamai requested review from mjac0bs and cpathipa January 11, 2024 21:54

abailly-akamai approved these changes Jan 16, 2024

View reviewed changes

fix spelling of LoadBalancerEndpontHeath ➡️ `LoadBalancerEndpointHe…

36ee5b8

…alth`

bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 16, 2024

mjac0bs reviewed Jan 16, 2024

View reviewed changes

bnussman added 4 commits January 16, 2024 14:27

add minimum with to skeleton so that loading state is not tiny

54d0339

hide Endpoints: if there is no status for a configuration

19fc4e3

update tense Added ➡️ Add in the changeset

40ccdaf

Make Configurations health behavior consistent with others

894db74

bnussman-akamai requested a review from mjac0bs January 16, 2024 19:52

mjac0bs approved these changes Jan 16, 2024

View reviewed changes

mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 16, 2024

bnussman-akamai merged commit be1d910 into linode:develop Jan 16, 2024
17 of 18 checks passed

This was referenced Jan 18, 2024

Release v1.110.0 - release → staging #10081

Closed

Release v1.110.0 - release → staging #10082

Merged

Release v1.110.0 - staging → master #10092

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7487] - Add AGLB Endpoint Health #10008

feat: [M3-7487] - Add AGLB Endpoint Health #10008

bnussman-akamai commented Dec 19, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2024 •

edited

Loading

abailly-akamai left a comment

abailly-akamai Jan 16, 2024

bnussman-akamai Jan 16, 2024

mjac0bs Jan 16, 2024

bnussman-akamai Jan 16, 2024

bnussman-akamai Jan 16, 2024

mjac0bs Jan 16, 2024

bnussman-akamai Jan 16, 2024

abailly-akamai Jan 16, 2024

bnussman-akamai Jan 16, 2024

abailly-akamai Jan 16, 2024 •

edited

Loading

bnussman-akamai Jan 16, 2024

mjac0bs left a comment •

edited

Loading

mjac0bs Jan 16, 2024

mjac0bs Jan 16, 2024

bnussman-akamai commented Jan 16, 2024

mjac0bs left a comment

bnussman-akamai commented Jan 16, 2024

		expect(upStatusIcon).toHaveStyle({ backgroundColor: '#17cf73' });
		expect(downStatusIcon).toHaveStyle({ backgroundColor: '#ca0813' });

feat: [M3-7487] - Add AGLB Endpoint Health #10008

feat: [M3-7487] - Add AGLB Endpoint Health #10008

Conversation

bnussman-akamai commented Dec 19, 2023 • edited Loading

Description 📝

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

github-actions bot commented Jan 11, 2024 • edited Loading

abailly-akamai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abailly-akamai Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjac0bs left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bnussman-akamai commented Jan 16, 2024

mjac0bs left a comment

Choose a reason for hiding this comment

bnussman-akamai commented Jan 16, 2024

bnussman-akamai commented Dec 19, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2024 •

edited

Loading

abailly-akamai Jan 16, 2024 •

edited

Loading

mjac0bs left a comment •

edited

Loading