Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-7578] - Placeholder and EntityDetails v7 storybook migrations #10019

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Dec 22, 2023

Description 📝

This is the last of the storybook migrations!! (excluding intro.stories.mdx which is here to stay due to being a docs only file)

  • Storybook migrations for Placeholder and Entity Details
  • added tests as well

How to test 🧪

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai marked this pull request as ready for review December 22, 2023 14:52
@coliu-akamai coliu-akamai requested a review from a team as a code owner December 22, 2023 14:52
@coliu-akamai coliu-akamai requested review from bnussman-akamai, cpathipa and abailly-akamai and removed request for a team December 22, 2023 14:52
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage looks good and Storybook stories render.

@mjac0bs mjac0bs added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Dec 29, 2023
Copy link

Coverage Report:
Base Coverage: 79.16%
Current Coverage: 79.24%

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 2, 2024
@bnussman-akamai bnussman-akamai merged commit 9fb22e6 into linode:develop Jan 2, 2024
18 checks passed
@coliu-akamai coliu-akamai deleted the last-mdx branch August 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants