Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-6616] - Add tests to update/rename linode label #10032

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

cliu-akamai
Copy link
Contributor

Description 📝

Add regression tests for updating/renaming the Linode label.

Major Changes 🔄

  • Add regression tests to update/rename a Linode label

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/update-linode-labels.spec.ts"

@cliu-akamai cliu-akamai requested a review from a team as a code owner January 4, 2024 20:33
@cliu-akamai cliu-akamai requested review from jdamore-linode and removed request for a team January 4, 2024 20:33
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are great, nice work @cliu-akamai!

Copy link

github-actions bot commented Jan 4, 2024

Coverage Report:
Base Coverage: 79.86%
Current Coverage: 79.86%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cassie, short and sweet tests!
Screenshot 2024-01-04 at 2 50 43 PM

All my comments are just to correct one variable typo.

Oh, and as Joe noted with a tag, can we please run yarn changeset and add a new changeset of type Test?

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 4, 2024
@cliu-akamai cliu-akamai requested a review from a team as a code owner January 10, 2024 13:38
@cliu-akamai cliu-akamai requested review from carrillo-erik and abailly-akamai and removed request for a team January 10, 2024 13:38
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Approving pending typos pointed out by @mjac0bs

@cliu-akamai cliu-akamai merged commit 9774383 into linode:develop Jan 12, 2024
17 of 18 checks passed
@cliu-akamai cliu-akamai deleted the feature/M3-6616 branch January 12, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Missing Changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants