Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: SD-598 - Ticket page small refresh #10054

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

nidillon
Copy link
Contributor

@nidillon nidillon commented Jan 10, 2024

Description 📝

The changes were requested from our support team, these changes would allow us to have an updated ticket page with the regards with a minor tweak in the wording of for the Akamai employee roles.

Changes 🔄

  • Changed Linode Expert -> Customer Support
  • Update Emotes for How did I do on the ticket page.

Preview 📷

Before After
image image
image image

How to test 🧪

Verification steps

  • To test open the ticket page as a normal user, and open a support ticket, once you receive a reply you will be able to see the updated names as well as the updated "How did I do?" emotes.
  • To view changes please reference the before and after photos provided above for each change.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@nidillon nidillon requested a review from a team as a code owner January 10, 2024 19:44
@nidillon nidillon requested review from dwiley-akamai and hana-akamai and removed request for a team January 10, 2024 19:44
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I added the changeset already, but FYI @nidillon it is done by running yarn changeset while on your branch and following the prompts. It'll generate a changeset entry for the PR which we use to help put together our changelogs for each release.

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nidillon! The two test failures can be disregarded (or alternatively can be fixed by merging in the latest from develop)

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Jan 11, 2024
Copy link

Coverage Report:
Base Coverage: 79.87%
Current Coverage: 79.87%

@bnussman-akamai bnussman-akamai merged commit c538a2a into linode:develop Jan 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants