Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7317] - Combine update and delete VPC tests #10061

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

carrillo-erik
Copy link
Contributor

Description 📝

This PR saves 1 test by combining the former update and delete VPC test on the VPC landing page.

Changes 🔄

  • Now, the combined test mocks two separate VPC instances. It updates one VPC, confirms the updates are reflected in the landing page, then deletes this VPC and confirms that the deletion is reflected in the landing page as well. Then, it deletes the second VPC instance and confirms that the deletion is reflected in the landing page by reverting back to the empty state of the VPC landing page.

Preview 📷

Before After
test-before test-after

How to test 🧪

Prerequisites

  • Ensure your account has the vpc-beta tag or have an account which does have the vpc-beta tag.

Reproduction steps

  • Run yarn cy:debug and use the UI to run the tests.
  • Run the test on your terminal using yarn cy:run -s "/path/to/local-manager-instance/manager/packages/manager/cypress/e2e/core/vpc/vpc-landing-page.spec.ts".

Verification steps

  • Verify that there are now four (4) Cypress tests compared to five (5) Cypress tests.
  • Verify that all tests are passing.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@carrillo-erik carrillo-erik requested a review from a team as a code owner January 12, 2024 17:58
@carrillo-erik carrillo-erik requested review from jdamore-linode and removed request for a team January 12, 2024 17:58
@carrillo-erik carrillo-erik self-assigned this Jan 12, 2024
@carrillo-erik carrillo-erik added VPC Relating to VPC project Testing labels Jan 12, 2024
@carrillo-erik carrillo-erik requested a review from a team as a code owner January 12, 2024 18:02
@carrillo-erik carrillo-erik requested review from hana-akamai and cpathipa and removed request for a team January 12, 2024 18:02
Copy link

github-actions bot commented Jan 12, 2024

Coverage Report:
Base Coverage: 79.87%
Current Coverage: 79.87%

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @carrillo-erik!

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that there are now 4 tests instead of 5 and that they all pass ✅

@hana-akamai hana-akamai added the Approved Multiple approvals and ready to merge! label Jan 16, 2024
@carrillo-erik carrillo-erik merged commit dcc6b60 into linode:develop Jan 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Testing VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants