test: [M3-7498] - Add Cypress tests for Parent/Child billing page UX enhancements #10070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 17, 2024 09:51
jdamore-linode
requested review from
cliu-akamai,
mjac0bs and
bnussman-akamai
and removed request for
a team
jdamore-linode
commented
Jan 17, 2024
| * | ||
| * @param tooltipText - Expected tooltip message to be shown to the user. | ||
| */ | ||
| const assertAddPaymentMethodDisabled = (tooltipText: string) => { |
There was a problem hiding this comment.
@jaalah-akamai quick question occurred to me while writing these tests: should the payment method action menus (or their items) be disabled for restricted and child users?
There was a problem hiding this comment.
Yes! Edit: Well let me triple check this.
Edit edit: 100% yes!
|
Just a note that I may add a temporary |
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jan 18, 2024
jaalah-akamai
approved these changes
Jan 18, 2024
jaalah-akamai
added
Approved
…d when applicable
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds Cypress tests to cover the UX enhancements made to the account Billing page for restricted and child users. Additionally updates Vitest and enables a Parent/Child unit test that was disabled due to an issue in older Vitest versions.
Changes 🔄
v1.0.4tov1.2.0ContactInformation.test.tsxHow to test 🧪
We should be able to rely on automated tests for this PR. Refer to the instructions below if you'd like to run the tests locally, however:
Prerequisites
Build and serve a Cloud Manager production build
Verification steps
Verify unit test change:
yarn test ContactInformation.testVerify Cypress test additions:
yarn cy:run -s "cypress/e2e/core/billing/restricted-user-billing.spec.ts"As an Author I have considered 🤔
Check all that apply