Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-7651] - Add Clone Linode power-off notice #10072

Merged
merged 4 commits into from
Jan 18, 2024
Merged

change: [M3-7651] - Add Clone Linode power-off notice #10072

merged 4 commits into from
Jan 18, 2024

Conversation

hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Jan 17, 2024 •
edited
Loading

Description 📝

This PR address sub-task 1 of M3-7580 Updates to Linode Clone UI.

I plan to release each sub-task directly to develop under a new feature flag, linodeCloneUIChanges.

Changes 🔄

  • Adds a new notice to the Clone Linodes flow recommending users power off their Linode before cloning

Preview 📷

Before After
Screenshot 2024-01-17 at 4 59 40 PM Screenshot 2024-01-17 at 4 59 25 PM

How to test 🧪

Prerequisites

  • Enable the "Linode Clone UI Changes" feature flag
  • Navigate to the Create Linode flow
  • Click on the "Clone Linode" tab
  • Verify a notice appears recommending users power off their Linode before cloning

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner January 17, 2024 22:04
@hkhalil-akamai hkhalil-akamai requested review from jdamore-linode and jaalah-akamai and removed request for a team January 17, 2024 22:04
@hkhalil-akamai hkhalil-akamai self-assigned this Jan 17, 2024
@hkhalil-akamai hkhalil-akamai added Linodes Dealing with the Linodes section of the app Linode Clone UI Updates labels Jan 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2024 •
edited
Loading

Coverage Report: ❌
Base Coverage: 79.92%
Current Coverage: 79.9%

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 18, 2024
jaalah-akamai
jaalah-akamai approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 18, 2024
@hkhalil-akamai hkhalil-akamai merged commit bd1ec82 into linode:develop Jan 18, 2024
18 checks passed
This was referenced Jan 18, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/frontend

Assignees

@hkhalil-akamai hkhalil-akamai

Labels
Approved Multiple approvals and ready to merge! Linodes Dealing with the Linodes section of the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hkhalil-akamai @bnussman-akamai @jaalah-akamai