upcoming: [M3-7599] - Update AGLB Configuration Ports Copy

[bnussman-akamai]

Description 📝

• Updates AGLB Configuration Ports Copy
• Tweaks form error handling so that it matches the behavior of other dynamic forms
• Updates the port dynamically if you choose HTTP or HTTPS when you haven't provided a custom port

Preview 📷

Before	After

How to test 🧪

Prerequisites

• Use the dev-test-aglb account
• Use the dev environment

Verification steps

• Go to http://localhost:3000/loadbalancers/13/configurations
• Click Add Configuration
• Check the copy on the ports field tooltip

As an Author I have considered 🤔

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[bnussman-akamai]

Is there a better way to handle this?

[jaalah-akamai]

You'll need to define some defaults first, but then you could do:

const defaultPort = {
    http: 80,
    https: 443,
    tcp: 80,
  };

  const handleProtocolChange = (protocol: Protocol) => {
    const { values, setFormikState } = formik;
    const { protocol: currentProtocol, port } = values;

    // Calculate the default port directly
    const newPort = port === defaultPort[currentProtocol] ? defaultPort[protocol] : port;

    setFormikState((prev) => ({
      ...prev,
      values: {
        ...values,
        port: newPort,
        protocol,
      },
    }));
  };

[bnussman-akamai]

That looks clean! I was mainly asking about having to maintain extra state (hasChangedPort). I don't think I can derive that with formik, but I'm not 100% sure

[jaalah-akamai]

Well that's what this does, no?

[github-actions]

Coverage Report: ✅
Base Coverage: 79.95%
Current Coverage: 79.95%

[carrillo-erik]

I was able to verify the update to the AGLB Configuration Ports Copy.

[jaalah-akamai]

This looks good regardless