-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7659] - Add user_type
to /profile
endpoint
#10080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
requested review from
dwiley-akamai and
abailly-akamai
and removed request for
a team
January 18, 2024 22:45
Coverage Report: ✅ |
Moving with an approach to add |
jaalah-akamai
changed the title
upcoming: [M3-7659] - Add account capabilities for user role
upcoming: [M3-7659] - Add Jan 19, 2024
user_type
to /profile
endpoint
mjac0bs
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
jaalah-akamai
requested review from
cliu-akamai
and removed request for
a team
January 19, 2024 19:41
carrillo-erik
approved these changes
Jan 19, 2024
bnussman-akamai
approved these changes
Jan 19, 2024
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We're updating our
/profile
endpoint to return the user role associated with Parent/Child Accounts by adding a newuser_type
field. Previous we had to get this information from the/users
or/users/:user
endpoint. This will allow us to cut down on the amount of queries we need in order to determine the user role.Changes 🔄
user_type
totype Profile
in APIv4useAccountUser
query hooksuser_type
for*/profile
similar to how we do for*/account/users/:user
.How to test 🧪
Prerequisites
Reproduction steps
Verification steps
Edit
andAdd Payment Method
buttons are disabled.Edit
andAdd Payment Method
buttons are enabled (by default we're in aparent
state)parent
tochild
on this lineEdit
andAdd Payment Method
buttons are disabled.child
toproxy
and observe theEdit
andAdd Payment Method
buttons are enabled.As an Author I have considered 🤔
Check all that apply