test: [M3-7483] - Add test to delete users on "Users & Grants" page #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliu-akamai
requested review from
jdamore-linode,
mjac0bs and
bnussman-akamai
and removed request for
a team
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Jan 22, 2024
| cy.wait(['@deleteUser', '@getUsers']); | ||
|
|
||
| // the user is deleted | ||
| cy.findByText(additionalUser.username).should('not.exist'); |
There was a problem hiding this comment.
Suggested change
| cy.findByText(additionalUser.username).should('not.exist'); | |
| ui.toast.assertMessage(`User ${additionalUser.username} has been deleted successfully.`); | |
| cy.findByText(additionalUser.username).should('not.exist'); |
This wasn't a ticket requirement, but it would be good to have the toast notification covered too!
| cy.findByText(mockUser.username).should('be.visible'); | ||
| cy.findByText(additionalUser.username).should('be.visible'); | ||
|
|
||
| // clickl the "x" button will dismiss the dialog and do nothing |
There was a problem hiding this comment.
Suggested change
| // clickl the "x" button will dismiss the dialog and do nothing | |
| // clicking the "x" button will dismiss the dialog and do nothing |
jdamore-linode
added
Add'tl Approval Needed
jdamore-linode
changed the title
mjac0bs
approved these changes
Jan 22, 2024
| ui.dialog.findByTitle('Confirm Deletion').within(() => { | ||
| ui.button.findByTitle('Cancel').should('be.visible').click(); | ||
| }); | ||
| // click the "Cancel" button will do nothing |
There was a problem hiding this comment.
Suggested change
| // click the "Cancel" button will do nothing | |
| // clicking the "Cancel" button will dismiss the dialog and do nothing |
There was a problem hiding this comment.
I agree with this small adjustment; it'll make it align with the comment for the next assertion too.
| cy.wait(['@deleteUser', '@getUsers']); | ||
|
|
||
| // the user is deleted | ||
| cy.findByText(additionalUser.username).should('not.exist'); |
mjac0bs
added
Approved
cliu-akamai
requested review from
dwiley-akamai and
jaalah-akamai
and removed request for
a team
dwiley-akamai
approved these changes
Jan 24, 2024
| ui.dialog.findByTitle('Confirm Deletion').within(() => { | ||
| ui.button.findByTitle('Cancel').should('be.visible').click(); | ||
| }); | ||
| // click the "Cancel" button will do nothing |
There was a problem hiding this comment.
I agree with this small adjustment; it'll make it align with the comment for the next assertion too.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add regression tests for deleting users on
Users & Grantspage.Major Changes 🔄
Users & Grantspage.How to test 🧪