-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7692] - VPC Action Buttons Incorrect Color in Dark Mode #10101
fix: [M3-7692] - VPC Action Buttons Incorrect Color in Dark Mode #10101
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colors display as expected in dark mode ✅
The "Impact" field on the ticket 😭
backgroundColor: theme.color.blueDTwhite, | ||
color: theme.color.white, | ||
backgroundColor: theme.color.blue, | ||
color: '#fff', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why doesn't theme.color.white
work here? Looks like it's supposed to, L62 in light.ts
is set to #fff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see in dark.ts
L57: white: '#32363c'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! fix works as expected 👍
Description 📝
Edit
andDelete
)Preview 📷
How to test 🧪
Edit
andDelete
buttons in both light ☀️ and dark mode 🌑As an Author I have considered 🤔