Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7692] - VPC Action Buttons Incorrect Color in Dark Mode #10101

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jan 24, 2024

Description 📝

Preview 📷

Before After
Screenshot 2024-01-23 at 8 54 50 PM Screenshot 2024-01-23 at 8 54 40 PM

How to test 🧪

  • Go to VPC details page
  • Check the colors of the Edit and Delete buttons in both light ☀️ and dark mode 🌑

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added Bug Fixes for regressions or bugs VPC Relating to VPC project labels Jan 24, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jan 24, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 24, 2024 02:05
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and jaalah-akamai and removed request for a team January 24, 2024 02:05
Copy link

github-actions bot commented Jan 24, 2024

Coverage Report:
Base Coverage: 80.18%
Current Coverage: 80.18%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors display as expected in dark mode ✅

The "Impact" field on the ticket 😭

backgroundColor: theme.color.blueDTwhite,
color: theme.color.white,
backgroundColor: theme.color.blue,
color: '#fff',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't theme.color.white work here? Looks like it's supposed to, L62 in light.ts is set to #fff

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently theme.color.white is kind of a lie. In dark mode it is not white

Screenshot 2024-01-24 at 10 32 30 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see in dark.ts L57: white: '#32363c'

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 25, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! fix works as expected 👍

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 25, 2024
@bnussman-akamai bnussman-akamai merged commit 21dbf07 into linode:develop Jan 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs VPC Relating to VPC project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants