Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-7701] - Add new ACLB Logo #10105

Merged
merged 4 commits into from
Jan 25, 2024
Merged

upcoming: [M3-7701] - Add new ACLB Logo #10105

merged 4 commits into from
Jan 25, 2024

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Jan 24, 2024 •
edited
Loading

Description 📝

  • Adds new ACLB Logo

Preview 📷

Before After
Screenshot 2024-01-24 at 5 05 25 PM Screenshot 2024-01-24 at 5 05 10 PM
Screenshot 2024-01-24 at 5 10 03 PM Screenshot 2024-01-24 at 5 08 58 PM

How to test 🧪

Prerequisites

  • Have ACLB feature flag enabled

Verification steps

  • Pull this PR or go to the preview link
  • Verify you see the new ACLB logo in the primary navigation
  • Verify you see the new ACLB logo in the Add New Menu

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added Ready for Review ACLB Relating to the Akamai Cloud Load Balancer labels Jan 24, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jan 24, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 24, 2024 22:12
@bnussman-akamai bnussman-akamai requested review from dwiley-akamai and jaalah-akamai and removed request for a team January 24, 2024 22:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 80.18%
Current Coverage: 80.18%

abailly-akamai
abailly-akamai approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Jan 25, 2024
mjac0bs
mjac0bs approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the new logo is visible in the top menu and primary nav and looks good in both light and dark mode.

🎉
Screenshot 2024-01-25 at 8 43 19 AM
Screenshot 2024-01-25 at 8 43 46 AM

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 25, 2024
@bnussman-akamai bnussman-akamai merged commit e0689bd into linode:develop Jan 25, 2024
18 checks passed
@cpathipa cpathipa mentioned this pull request Feb 1, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

@dwiley-akamai dwiley-akamai Awaiting requested review from dwiley-akamai dwiley-akamai is a code owner automatically assigned from linode/frontend

@jaalah-akamai jaalah-akamai Awaiting requested review from jaalah-akamai jaalah-akamai is a code owner automatically assigned from linode/frontend

Assignees

@bnussman-akamai bnussman-akamai

Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @mjac0bs @abailly-akamai @bnussman