Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7707] - Change AGLB Rule Execution Order Column Header and Values #10112

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Changes ACLB Rule table column Execution ➡️ Execution Order
  • Changes the values First 2 3 Last to 1 2 3 4
  • This is a change requested by UX

Preview 📷

Before After
Screenshot 2024-01-25 at 4 09 38 PM Screenshot 2024-01-25 at 4 08 54 PM

How to test 🧪

Prerequisites

  • Login to dev-test-aglb account using the dev API or use the MSW to test this

Verification steps

  • Go to an AGLB
  • View rules on any route
  • Verify the rules has an Execution Order column
  • Verify the rules Execution Order column has numeric values 1 2 3 4

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the ACLB Relating to the Akamai Cloud Load Balancer label Jan 25, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jan 25, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 25, 2024 21:14
@bnussman-akamai bnussman-akamai requested review from jdamore-linode and mjac0bs and removed request for a team January 25, 2024 21:14
Copy link

Coverage Report:
Base Coverage: 80.33%
Current Coverage: 80.33%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid UX improvement. Confirmed that Execution Order is the column header and numerical values replaced First and Last rules. No regressions to reordering the rules, adding a rule, or deleting a rule.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 25, 2024
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner 🧼

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 29, 2024
@bnussman-akamai bnussman-akamai merged commit c43b09e into linode:develop Jan 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants