Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7710] - Table Collapsible row icon orientation #10119

Merged
merged 3 commits into from
Jan 30, 2024
Merged

change: [M3-7710] - Table Collapsible row icon orientation #10119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5e01ab
Change collapsible row icon orientation
abailly-akamai Jan 29, 2024
950e74e
Added changeset: Table Collapsible row icon orientation
abailly-akamai Jan 29, 2024
f8f30f0
Fix e2e suite
abailly-akamai Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10119-changed-1706549896002.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Changed
---

Table Collapsible row icon orientation ([#10119](https://github.com/linode/manager/pull/10119))
4 changes: 2 additions & 2 deletions packages/manager/cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ describe('Akamai Global Load Balancer routes page', () => {
'@getRoutes',
]);

cy.findByLabelText(`route-${routes[0].id} expand row`).click();
cy.findByLabelText(`expand route-${routes[0].id} row`).click();

ui.actionMenu.findByTitle('Action Menu for Rule 0').click();

Expand Down Expand Up @@ -600,7 +600,7 @@ describe('Akamai Global Load Balancer routes page', () => {
]);

// Expand the route table
cy.findByLabelText(`route-${routes[0].id} expand row`).click();
cy.findByLabelText(`expand route-${routes[0].id} row`).click();

// Verify all rules are shown
for (const rule of routes[0].rules) {
Expand Down
6 changes: 3 additions & 3 deletions packages/manager/src/components/CollapsibleTable/CollapsibleRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import KeyboardArrowDownIcon from '@mui/icons-material/KeyboardArrowDown';
import KeyboardArrowUpIcon from '@mui/icons-material/KeyboardArrowUp';
import KeyboardArrowRightIcon from '@mui/icons-material/KeyboardArrowRight';
import Box from '@mui/material/Box';
import Collapse from '@mui/material/Collapse';
import IconButton from '@mui/material/IconButton';
Expand All @@ -25,12 +25,12 @@ export const CollapsibleRow = (props: Props) => {
<StyledOuterTableRow>
<TableCell component="th" scope="row">
<IconButton
aria-label={`${label} expand row`}
aria-label={`expand ${label} row`}
mjac0bs marked this conversation as resolved.
Show resolved Hide resolved
onClick={() => setOpen(!open)}
size="small"
sx={{ padding: 1 }}
>
{open ? <KeyboardArrowUpIcon /> : <KeyboardArrowDownIcon />}
{open ? <KeyboardArrowDownIcon /> : <KeyboardArrowRightIcon />}
</IconButton>
{label}
</TableCell>
Expand Down
Loading