-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-7720] - Refactor AccessKeyTable - Eliminate react anti patterns #10124
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpathipa |
...s/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyTable/AccessKeyActionMenu.tsx
Outdated
Show resolved
Hide resolved
I was able to verify that I can create/update/revoke access keys after the changes. One thing I also noticed was that there are associated events with the actions I've mentioned, however, we do not show any toast notifications. |
Description 📝
How to test 🧪
(How to verify changes)
As an Author I have considered 🤔
Check all that apply