Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom breadcrumb for NodeBalancers details page #10127

Merged

Conversation

hkhalil-akamai
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai commented Jan 30, 2024

Description 📝

Adds a custom label to the NodeBalancerDetail & NodeBalancerCreate breadcrumb labels. This eliminates the inconsistent capitalization between "Nodebalancers" and "NodeBalancers".

Changes 🔄

  • "Nodebalancers" ➡️ "NodeBalancers" in the NodeBalancers details & create breadcrumb labels

Preview 📷

Include a screenshot or screen recording of the change

Before After
Screenshot 2024-01-30 at 1 06 34 PM Screenshot 2024-01-30 at 1 06 42 PM
Screenshot 2024-01-30 at 1 29 19 PM Screenshot 2024-01-30 at 1 29 30 PM

How to test 🧪

Verification steps

  • Navigate to the details page for a NodeBalancer
  • Verify the word NodeBalancers appears with the correct capitalization in the breadcrumb
  • Repeat for the create page for a NodeBalancer

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hkhalil-akamai hkhalil-akamai self-assigned this Jan 30, 2024
@hkhalil-akamai hkhalil-akamai marked this pull request as ready for review January 30, 2024 18:10
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner January 30, 2024 18:10
@hkhalil-akamai hkhalil-akamai requested review from mjac0bs and jaalah-akamai and removed request for a team January 30, 2024 18:10
@hkhalil-akamai hkhalil-akamai force-pushed the nodebalancer-detail-breadcrumb branch from 94b7a7b to b483d3b Compare January 30, 2024 18:32
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the breadcrumb says NodeBalancers on the details and create pages now. 🚀

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 30, 2024
Copy link

github-actions bot commented Jan 30, 2024

Coverage Report:
Base Coverage: 81.21%
Current Coverage: 81.21%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Jan 31, 2024
@hkhalil-akamai hkhalil-akamai merged commit 9071c59 into linode:develop Jan 31, 2024
18 checks passed
@hkhalil-akamai hkhalil-akamai deleted the nodebalancer-detail-breadcrumb branch January 31, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants