Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7435, M3-7637] - Cypress tests for OBJ Multicluster access key management #10144

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

This adds 3 Cypress tests to confirm access key user flows when the OBJ Multicluster feature is enabled.

I added the Wait to Merge label because I'd like to wait for PR #10118 to be merged, at which point I'll push a couple changes here and then will remove the label. I added a couple TODO comments to mark the spots in the tests that will be impacted by the PR.

Changes 🔄

  • Added Cypress tests in objectStorage/access-keys.smoke.spec.ts:
    • can create unlimited access keys with OBJ Multicluster
    • can create limited access keys with OBJ Multicluster
    • can update access keys with OBJ Multicluster
  • Added a couple intercept utils
  • Added a QA data attribute to the selection list component

How to test 🧪

Prerequisites

yarn && yarn build && yarn start:manager:ci

Verification steps

yarn cy:run -s "cypress/e2e/core/objectStorage/access-keys.smoke.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

Copy link

github-actions bot commented Feb 5, 2024

Coverage Report:
Base Coverage: 81.12%
Current Coverage: 81.12%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jdamore-linode

});

ui.actionMenuItem
// TODO M3-7696 Replace 'Edit Label' with 'Edit' upon merging #10118.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #10118 is merged we can update the TODO.

.click();

ui.drawer
// TODO M3-7697 Replace 'Edit Access Key Label' with 'Edit Access Key' upon merging #10118.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

.should('be.visible')
.within(() => {
mockBuckets.forEach((mockBucket) => {
// TODO M3-7733 Update this selector when ARIA label is fixed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jdamore-linode for creating the ticket.

@jdamore-linode
Copy link
Contributor Author

Thanks @cpathipa! Just merged in develop and updated the tests accordingly -- if everything passes I'll plan to merge 👍

@jdamore-linode jdamore-linode added Approved Multiple approvals and ready to merge! and removed Wait to Merge Ready for Review labels Feb 9, 2024
@jdamore-linode jdamore-linode merged commit c8e291e into linode:develop Feb 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! OBJ Multi-Cluster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants