Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7611] - Placement Groups Detail Summary #10164
upcoming: [M3-7611] - Placement Groups Detail Summary #10164
Changes from 6 commits
e38ee46
342169c
869c4d8
4a4db26
816c885
82f8367
ec51f13
e74ed23
9564a61
39b0dba
7f3707d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Notice should live inside the
PlacementGroupSummary
componentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abailly-akamai I had originally done this, however, having the
<Notice />
inside the<PlacementGroupSummary />
was the reason why the unit test was failing. This led me to rethink about the component composition and I feel the<Notice />
should live outside of the<PlacementGroupSummary />
as this component is only meant to display the config details. It's a personal preference but if you believe otherwise I can make the change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that test failure should warrant this change. The notice only pertains to the summary so it should be there. You put it in the
SafeTabPanel
which isn't right. Let's put it back inside the summary and fix the test. I can help if you can't find the source of the failureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't use a constant and instead incorporated the string right in the component, this seems to have solved the issue I was encountering with the unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: we could also check if the tooltip exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included this check in the unit test.