Release v1.112.0 - release → staging

docs/development-guide/08-testing.md

@@ -45,7 +45,7 @@ Test execution will stop at the debugger statement, and you will be able to use
 
 ### React Testing Library
 
-We have some older tests that still use the Enzyme framework, but for new tests we generally use [React Testing Library](https://testing-library.com/docs/react-testing-library/intro). This library provides a set of tools to render React components from within the Vitest environment. The library's philosophy is that components should be tested as closely as possible to how they are used.
+This library provides a set of tools to render React components from within the Vitest environment. The library's philosophy is that components should be tested as closely as possible to how they are used.
 
 A simple test using this library will look something like this:
 

packages/api-v4/src/object-storage/objectStorageKeys.ts

@@ -1,4 +1,7 @@
-import { createObjectStorageKeysSchema } from '@linode/validation/lib/objectStorageKeys.schema';
+import {
+  createObjectStorageKeysSchema,
+  updateObjectStorageKeysSchema,
+} from '@linode/validation/lib/objectStorageKeys.schema';
 import { API_ROOT } from '../constants';
 import Request, {
   setData,
@@ -51,7 +54,7 @@ export const updateObjectStorageKey = (
   Request<ObjectStorageKey>(
     setMethod('PUT'),
     setURL(`${API_ROOT}/object-storage/keys/${encodeURIComponent(id)}`),
-    setData(data, createObjectStorageKeysSchema)
+    setData(data, updateObjectStorageKeysSchema)
   );
 
 /**

packages/api-v4/src/placement-groups/placement-groups.ts

@@ -1,7 +1,5 @@
 import {
-  assignVMsToPlacementGroupSchema,
   createPlacementGroupSchema,
-  unassignVMsFromPlacementGroupSchema,
   renamePlacementGroupSchema,
 } from '@linode/validation';
 import { API_ROOT } from '../constants';
@@ -15,10 +13,10 @@ import Request, {
 } from '../request';
 import type { Filter, Params, ResourcePage as Page } from '../types';
 import type {
-  AssignVMsToPlacementGroupPayload,
+  AssignLinodesToPlacementGroupPayload,
   CreatePlacementGroupPayload,
   PlacementGroup,
-  UnassignVMsFromPlacementGroupPayload,
+  UnassignLinodesFromPlacementGroupPayload,
   RenamePlacementGroupPayload,
 } from './types';
 
@@ -109,9 +107,9 @@ export const deletePlacementGroup = (placementGroupId: number) =>
  *
  * @note While this accepts an array of Linode ids (future proofing), only one Linode id is supported at this time.
  */
-export const assignVMsToPlacementGroup = (
+export const assignLinodesToPlacementGroup = (
   placementGroupId: number,
-  linodeIds: AssignVMsToPlacementGroupPayload
+  payload: AssignLinodesToPlacementGroupPayload
 ) =>
   Request<PlacementGroup>(
     setURL(
@@ -120,7 +118,7 @@ export const assignVMsToPlacementGroup = (
       )}/assign`
     ),
     setMethod('POST'),
-    setData(linodeIds, assignVMsToPlacementGroupSchema)
+    setData(payload)
   );
 
 /**
@@ -133,9 +131,9 @@ export const assignVMsToPlacementGroup = (
  *
  * @note While this accepts an array of Linode ids (future proofing), only one Linode id is supported at this time.
  */
-export const unassignVMsFromPlacementGroup = (
+export const unassignLinodesFromPlacementGroup = (
   placementGroupId: number,
-  linodeIds: UnassignVMsFromPlacementGroupPayload
+  payload: UnassignLinodesFromPlacementGroupPayload
 ) =>
   Request<PlacementGroup>(
     setURL(
@@ -144,5 +142,5 @@ export const unassignVMsFromPlacementGroup = (
       )}/unassign`
     ),
     setMethod('POST'),
-    setData(linodeIds, unassignVMsFromPlacementGroupSchema)
+    setData(payload)
   );

packages/api-v4/src/placement-groups/types.ts

@@ -27,5 +27,9 @@ export type RenamePlacementGroupPayload = Pick<PlacementGroup, 'label'>;
 /**
  * Since the API expects an array of ONE linode id, we'll use a tuple here.
  */
-export type AssignVMsToPlacementGroupPayload = [number];
-export type UnassignVMsFromPlacementGroupPayload = [number];
+export type AssignLinodesToPlacementGroupPayload = {
+  linodes: [number];
+};
+export type UnassignLinodesFromPlacementGroupPayload = {
+  linodes: [number];
+};

packages/manager/CHANGELOG.md

@@ -4,6 +4,43 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2024-02-12] - v1.112.0
+
+
+### Fixed:
+
+- EditableText interaction styling ([#10132](https://github.com/linode/manager/pull/10132))
+- Unit tests Button enabled assertions ([#10142](https://github.com/linode/manager/pull/10142))
+- Error when enabling backups for Linodes in regions with $0 pricing ([#10153](https://github.com/linode/manager/pull/10153))
+- Allow IPv6 ranges transfers ([#10156](https://github.com/linode/manager/pull/10156))
+- Error notices for $0 regions in LKE Resize and Add Node Pools drawers ([#10157](https://github.com/linode/manager/pull/10157))
+- Error in Enable All Backups drawer when one or more Linode is in a $0 region ([#10161](https://github.com/linode/manager/pull/10161))
+- Display $0.00 prices in Linode Migration dialog ([#10166](https://github.com/linode/manager/pull/10166))
+
+### Tech Stories:
+
+- DC Get Well - Cleanup/Remove feature flag logic ([#10146](https://github.com/linode/manager/pull/10146))
+- Clean up `regionDropdown` feature flag ([#10148](https://github.com/linode/manager/pull/10148))
+- Update `react-router-dom` in preparation for React 18 ([#10154](https://github.com/linode/manager/pull/10154))
+- Remove Enzyme ([#10160](https://github.com/linode/manager/pull/10160))
+- Update `launchdarkly-react-client-sdk` ([#10165](https://github.com/linode/manager/pull/10165))
+
+### Tests:
+
+- Add integration test coverage for Account Login History ([#10125](https://github.com/linode/manager/pull/10125))
+- Add test to check proxy user disabled username/email field ([#10139](https://github.com/linode/manager/pull/10139))
+- Add Cypress tests for OBJ Multicluster access key operations ([#10144](https://github.com/linode/manager/pull/10144))
+- Fix billing contact Cypress test by narrowing element selection scope ([#10150](https://github.com/linode/manager/pull/10150))
+
+### Upcoming Features:
+
+- Create Placement Groups Select component ([#10100](https://github.com/linode/manager/pull/10100))
+- Cleanup files to use profile to get user_type ([#10102](https://github.com/linode/manager/pull/10102))
+- "Save" button in Edit Access Key drawer disabled unless field values are changed ([#10118](https://github.com/linode/manager/pull/10118))
+- Add Placement Group Linodes List ([#10123](https://github.com/linode/manager/pull/10123))
+- Improve restricted access Login History experience for child and restricted users ([#10125](https://github.com/linode/manager/pull/10125))
+- Add AssignLinodesToPlacementGroup drawer ([#10140](https://github.com/linode/manager/pull/10140))
+
 ## [2024-02-05] - v1.111.0
 ### Changed:
 

packages/manager/cypress/e2e/core/account/account-login-history.spec.ts

@@ -0,0 +1,195 @@
+/**
+ * @file Integration tests for Cloud Manager account login history flows.
+ */
+
+import { accountFactory, profileFactory } from 'src/factories';
+import { accountLoginFactory } from 'src/factories/accountLogin';
+import { formatDate } from 'src/utilities/formatDate';
+import {
+  mockGetAccount,
+  mockGetAccountLogins,
+} from 'support/intercepts/account';
+import {
+  mockAppendFeatureFlags,
+  mockGetFeatureFlagClientstream,
+} from 'support/intercepts/feature-flags';
+import { mockGetProfile } from 'support/intercepts/profile';
+import { makeFeatureFlagData } from 'support/util/feature-flags';
+
+describe('Account login history', () => {
+  /*
+   * - Confirms that a user can navigate to and view the login history page.
+   * - Confirms that login table displays the expected column headers.
+   * - Confirms that the login table displays a mocked failed restricted user login.
+   * - Confirm that the login table displays a mocked successful unrestricted user login.
+   */
+  it('users can view the login history table', () => {
+    const mockAccount = accountFactory.build();
+    const mockProfile = profileFactory.build({
+      username: 'mock-user',
+      restricted: false,
+      user_type: null,
+    });
+    const mockFailedLogin = accountLoginFactory.build({
+      status: 'failed',
+      username: 'mock-restricted-user',
+      restricted: true,
+    });
+    const mockSuccessfulLogin = accountLoginFactory.build({
+      status: 'successful',
+      restricted: false,
+    });
+
+    mockGetAccount(mockAccount).as('getAccount');
+    mockGetProfile(mockProfile).as('getProfile');
+    mockGetAccountLogins([mockFailedLogin, mockSuccessfulLogin]).as(
+      'getAccountLogins'
+    );
+
+    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
+    mockAppendFeatureFlags({
+      parentChildAccountAccess: makeFeatureFlagData(false),
+    }).as('getFeatureFlags');
+    mockGetFeatureFlagClientstream().as('getClientStream');
+
+    // Navigate to Account Login History page.
+    cy.visitWithLogin('/account/login-history');
+    cy.wait([
+      '@getAccount',
+      '@getClientStream',
+      '@getFeatureFlags',
+      '@getProfile',
+    ]);
+
+    // Confirm helper text above table is visible.
+    cy.findByText(
+      'Logins across all users on your account over the last 90 days.'
+    ).should('be.visible');
+
+    // Confirm the login table includes the expected column headers and mocked logins are visible in table.
+    cy.findByLabelText('Account Logins').within(() => {
+      cy.get('thead').findByText('Date').should('be.visible');
+      cy.get('thead').findByText('Username').should('be.visible');
+      cy.get('thead').findByText('IP').should('be.visible');
+      cy.get('thead').findByText('Permission Level').should('be.visible');
+      cy.get('thead').findByText('Access').should('be.visible');
+
+      // Confirm that restricted user's failed login and status icon display in table.
+      cy.findByText(mockFailedLogin.username)
+        .should('be.visible')
+        .closest('tr')
+        .within(() => {
+          cy.findByText(mockFailedLogin.status, { exact: false }).should(
+            'be.visible'
+          );
+          cy.findAllByLabelText(`Status is ${mockFailedLogin.status}`);
+          cy.findByText('Restricted').should('be.visible');
+        });
+
+      // Confirm that unrestricted user login displays in table.
+      cy.findByText(mockSuccessfulLogin.username)
+        .should('be.visible')
+        .closest('tr')
+        .within(() => {
+          // Confirm that successful login and status icon display in table.
+          cy.findByText(mockSuccessfulLogin.status, { exact: false }).should(
+            'be.visible'
+          );
+          cy.findAllByLabelText(`Status is ${mockSuccessfulLogin.status}`);
+
+          // Confirm all other fields display in table.
+          cy.findByText(
+            formatDate(mockSuccessfulLogin.datetime, {
+              timezone: mockProfile.timezone,
+            })
+          ).should('be.visible');
+          cy.findByText(mockSuccessfulLogin.ip).should('be.visible');
+          cy.findByText('Unrestricted').should('be.visible');
+        });
+    });
+  });
+
+  /**
+   * - Confirms that a child user can navigate to the Login History page.
+   * - Confirms that a child user cannot see login history data.
+   * - Confirms that a child user sees a notice instead.
+   */
+  it('child users cannot view login history', () => {
+    const mockAccount = accountFactory.build();
+    const mockProfile = profileFactory.build({
+      username: 'mock-child-user',
+      restricted: false,
+      user_type: 'child',
+    });
+
+    mockGetAccount(mockAccount).as('getAccount');
+    mockGetProfile(mockProfile).as('getProfile');
+
+    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
+    mockAppendFeatureFlags({
+      parentChildAccountAccess: makeFeatureFlagData(true),
+    }).as('getFeatureFlags');
+    mockGetFeatureFlagClientstream().as('getClientStream');
+
+    // Navigate to Account Login History page.
+    cy.visitWithLogin('/account/login-history');
+    cy.wait([
+      '@getAccount',
+      '@getClientStream',
+      '@getFeatureFlags',
+      '@getProfile',
+    ]);
+
+    // Confirm helper text above table and table are not visible.
+    cy.findByText(
+      'Logins across all users on your account over the last 90 days.'
+    ).should('not.exist');
+    cy.findByLabelText('Account Logins').should('not.exist');
+
+    cy.findByText(
+      'Access restricted. Please contact your business partner to request the necessary permission.'
+    );
+  });
+
+  /**
+   * - Confirms that a restricted user can navigate to the Login History page.
+   * - Confirms that a restricted user cannot see login history data.
+   * - Confirms that a restricted user sees a notice instead.
+   */
+  it('restricted users cannot view login history', () => {
+    const mockAccount = accountFactory.build();
+    const mockProfile = profileFactory.build({
+      username: 'mock-restricted-user',
+      restricted: true,
+      user_type: null,
+    });
+
+    mockGetProfile(mockProfile).as('getProfile');
+    mockGetAccount(mockAccount).as('getAccount');
+
+    // TODO: Parent/Child - M3-7559 clean up when feature is live in prod and feature flag is removed.
+    mockAppendFeatureFlags({
+      parentChildAccountAccess: makeFeatureFlagData(true),
+    }).as('getFeatureFlags');
+    mockGetFeatureFlagClientstream().as('getClientStream');
+
+    // Navigate to Account Login History page.
+    cy.visitWithLogin('/account/login-history');
+    cy.wait([
+      '@getAccount',
+      '@getClientStream',
+      '@getFeatureFlags',
+      '@getProfile',
+    ]);
+
+    // Confirm helper text above table and table are not visible.
+    cy.findByText(
+      'Logins across all users on your account over the last 90 days.'
+    ).should('not.exist');
+    cy.findByLabelText('Account Logins').should('not.exist');
+
+    cy.findByText(
+      'Access restricted. Please contact your account administrator to request the necessary permission.'
+    );
+  });
+});