refactor: [M3-7800] - Clean up new QueryClient() pattern in unit tests
#10217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
jdamore-linode and
carrillo-erik
and removed request for
a team
|
Coverage Report: ❌ |
hkhalil-akamai
approved these changes
Feb 23, 2024
Comment on lines
-47
to
-51
| setLogger({ | ||
| log: () => {}, | ||
| warn: () => {}, | ||
| error: () => {}, | ||
| }); |
There was a problem hiding this comment.
I think it was a way to hide some console warning/errors, but I don't think we need to do it anymore. I don't see any React Query specific errors in our test logs
abailly-akamai
approved these changes
Feb 26, 2024
bnussman-akamai
added
Approved
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
new QueryClient()instances 🧹new QueryClient()in our unit test because we were having issues with unit tests sharing the same React QueryQueryClientand cache. It was causing flakiness. Today,wrapWithThemecreate a newQueryClienteach time it is called and Vitest ensures each test runs in isolation. We shouldn't need to donew QueryClient()in our unit test because they are isolated by default 📙How to test 🧪
Verification steps
yarn testlocally 💻As an Author I have considered 🤔