-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7817] - Show correct status of Child Account Enabled column for parent users #10233
Merged
mjac0bs
merged 5 commits into
linode:develop
from
mjac0bs:M3-7817-correct-child-account-access-status
Mar 8, 2024
Merged
fix: [M3-7817] - Show correct status of Child Account Enabled column for parent users #10233
mjac0bs
merged 5 commits into
linode:develop
from
mjac0bs:M3-7817-correct-child-account-access-status
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
force-pushed
the
M3-7817-correct-child-account-access-status
branch
from
February 28, 2024 17:41
297b524
to
0aea463
Compare
mjac0bs
requested review from
jdamore-linode and
carrillo-erik
and removed request for
a team
March 8, 2024 15:59
bnussman-akamai
approved these changes
Mar 8, 2024
jaalah-akamai
approved these changes
Mar 8, 2024
mjac0bs
added
Approved
Multiple approvals and ready to merge!
and removed
Ready for Review
labels
Mar 8, 2024
Coverage Report: ✅ |
CI failure was on |
vrajesh73
added a commit
to vrajesh73/manager
that referenced
this pull request
Mar 12, 2024
…eature/namespace-create * 'develop' of https://github.com/vrajesh73/manager: (89 commits) fix: [M3-7269] - Display parent email in user menu when no company name is available for restricted parent user (linode#10248) fix: [M3-7817] - Show correct status of Child Account Enabled column for parent users (linode#10233) upcoming: [M3-7616] - Add Placement Groups Events and Notifications (linode#10221) upcoming: [M3-7816-v2] - Adjust logic for when to show Switch Account button (linode#10266) fix: [M3-7831] - Persisting error messages in ACLB delete dialogs (linode#10254) upcoming: [M3-7842] - Update Assign Linode Drawer and improve query skipping (linode#10263) upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions (linode#10222) test: Fix test flake for Images landing page test (linode#10267) fix: [M3-7824] - ACLB TCP Rule Creation and other fixes (linode#10264) refactor: [M3-7687] - Linodes Restricted User Experience 2/2 (linode#10227) test: Resolve OBJ create and delete E2E test flake (linode#10245) upcoming: [M3-7723] - Placement Group feature flag as object (linode#10256) chore(deps): Bump sanitize-html from 2.11.0 to 2.12.1 (linode#10247) change: [M3-7813] - Allow the disabling of the TypeToConfirm input (linode#10251) upcoming: [M3-7839] - Change Business Partner to Parent User (linode#10259) upcoming: [M3-7835] - Adjust user table column count (linode#10252) upcoming: [M3 7738] - Update Placement Group Create & Edit Drawers (linode#10205) refactor: [M3-7437] - Use `@lukemorales/query-key-factory` for Profile Queries (linode#10241) fix: React Query `updateInPaginatedStore` helper function not working as expected (linode#10249) test: [M3-7497] - Add tests for child user verification banner (linode#10204) ... # Conflicts: # packages/manager/src/MainContent.tsx # packages/manager/src/dev-tools/FeatureFlagTool.tsx
This was referenced Mar 18, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
Bug
Fixes for regressions or bugs
Parent / Child Account
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We need to fix our conditional that is rendering either "Disabled" or "Enabled" in the Child Account Access column of the Users & Grants table. This grant can be set for restricted parent users, by an unrestricted parent user, to determine whether that restricted parent can access child accounts.
Currently, Child Account Access on http://localhost:3000/account/users is “Disabled” for unrestricted parent users, which is not correct; it should be “Enabled”. This was a logic error - our check for grants is going to return
undefined
(and evaluate to "Disabled") for unrestricted parent users because we don't check grants for unrestricted users.We should also confirm that the Child Account Access column updates as expected (to "Enabled") after a restricted parent is granted access.
Changes 🔄
Note
Test coverage for these changes will be in the related test ticket, M3-7500. (#10240)
Preview 📷
|
How to test 🧪
Prerequisites
(How to setup test environment)
unrestricted-parent-user
and another without full account accessrestricted-parent-user
.Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
yarn dev
and switch to the dev environment.child_account_access
grant istrue
and Disabled if thechild_account_access
grant isfalse
.restricted-parent-user
and toggle the "Enable child account access" general permission. Then go back to the Users Landing page and confirm the value has updated as expected.As an Author I have considered 🤔
Check all that apply