-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7860] - Source ACLB region info from API data and use Jakarta instead of Sydney #10274
change: [M3-7860] - Source ACLB region info from API data and use Jakarta instead of Sydney #10274
Conversation
โฆa instead of Sydney
Coverage Report: โ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do find it weird that at times we'll only display the region id, but I'm sure that's temporary?
โ
Confirmed empty flag state in dev and that Jakarta (id-cgk) displays instead of Sidney (Region Id only)
โ
Confirmed flags display in prod account and that Jakarta (id-cgk) displays instead of Sidney
Yeah, it's not great @jaalah-akamai. It's more of a configuration problem. The VMs that run the underlying ACLBs are deployed in regions that don't exist in alpha. What really should have happened is that alpha ACLBs should be using alpha only regions (basically just Newark), but they chose to deploy alpha ACLBs nodes using production Linodes. We could continue to hardcode the values to keep alpha looking nice but I don't think we should be doing that to cover up for other team's design choices. |
I was able to verify both user accounts by logging into both environments as described in the PR description. Really appreciate the comment blocks this PR removes, every bit helps. Also, the refactor of the |
Description ๐
Preview ๐ท
How to test ๐งช
Note
Behavior will be different in dev compared to production because dev lacks certain regions in the API response.
You should test this PR using both dev and production
Testing dev
dev-test-aglb
Yes, this is expected:
Testing staging/production
prod-test-065
As an Author I have considered ๐ค