feat: [M3-7829] - Linode Clone UI refinements #10280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-akamai
requested review from
bnussman-akamai and
abailly-akamai
and removed request for
a team
hana-akamai
commented
Mar 13, 2024
Comment on lines
-89
to
-97
| if (linodeLoading || !linode) { | ||
| return ( | ||
| <TableRow> | ||
| <TableCell colSpan={numCols}> | ||
| <CircleProgress mini /> | ||
| </TableCell> | ||
| </TableRow> | ||
| ); | ||
| } |
There was a problem hiding this comment.
This component doesn't need to manage it's own loading/error states anymore now that we're not fetching each individual Linode
| linodeId={linode.id} | ||
| linode={linode} |
There was a problem hiding this comment.
Just pass in the Linode instead of refetching it again in the component
bnussman-akamai
approved these changes
Mar 14, 2024
mjac0bs
added
Approved
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Address refinements identified during the review process for Clone UI changes
Changes 🔄
Preview 📷
Screen.Recording.2024-03-13.at.4.42.08.PM.mov
Screen.Recording.2024-03-13.at.4.47.44.PM.mov
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply