-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-7868] - Gecko Beta Demo feedback #10284
upcoming: [M3-7868] - Gecko Beta Demo feedback #10284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the described changes look good on my account with the customer tag! 🚢
I'm not sure what kind of test coverage you've got for Gecko, and whether you want to consider adding coverage for any of the warnings.
Also not specific to this PR: Our migrate warning list is so long. 😅 I wonder if customers actually read that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, created M3-7884 to address this
packages/manager/src/features/Linodes/MigrateLinode/CautionNotice.tsx
Outdated
Show resolved
Hide resolved
const edgeRegionWarning = | ||
flags.gecko && linodeIsInEdgeRegion | ||
? 'Edge sites may only be migrated to other Edge sites.' | ||
: undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: should this logic live in CautionNotice
?
packages/manager/src/features/Linodes/MigrateLinode/CautionNotice.tsx
Outdated
Show resolved
Hide resolved
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go to
/linodes/create
and select an Edge region- The edge plan table warning notice should say "billing" instead of "standard pricing" ✅
- The Storage column should display the storage amount instead of N/A ✅
- On the Linode landings table, open the action menu for a Linode located in an edge region and click on "Migrate"
- There should be a warning bullet about edge migrations in the Caution notice ✅
- Go to
/images/create/upload
and open the region select dropdown- There should be no edge regions displayed ✅
- Periods added for Edge-related warnings ✅
Description 📝
Address feedback from the Gecko Beta Demo/Review meeting
Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
Verification steps
/linodes/create
and select an Edge region/images/create/upload
and open the region select dropdownAs an Author I have considered 🤔
Check all that apply