Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-7431] - Add placement group to checkout summary #10304

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Mar 21, 2024

Description 📝

Very simple PR to add a placement group display section to the checkout summary: "Assigned to Placement Group"

Changes 🔄

  • Add placement group display section to the checkout summary

Preview 📷

Screenshot 2024-03-21 at 15 38 07

How to test 🧪

Prerequisites

  • Have both the "Placement Group" feature flag and MSW enabled

Verification steps

  • Go to http://localhost:3000/linodes/create
  • Select the "Newark, NJ" region
  • Scroll to the Details panel
  • Select a placement group in the drop down
  • Confirm the "Assigned to Placement Group" item in the checkout summary at the bottom of the page

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Mar 21, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review March 21, 2024 19:45
@abailly-akamai abailly-akamai requested a review from a team as a code owner March 21, 2024 19:45
@abailly-akamai abailly-akamai requested review from bnussman-akamai and hkhalil-akamai and removed request for a team March 21, 2024 19:45
Copy link

Coverage Report:
Base Coverage: 81.64%
Current Coverage: 81.64%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Text appears in checkout when the PG select has a value and otherwise does not.
✅ All the summary info is still wrapping and displaying cleanly.

Screenshot 2024-03-21 at 1 42 30 PM

Edit: and looks like an unrelated test failure on vpc/vpc-linodes-update.spec.ts.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Mar 21, 2024
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 21, 2024
@abailly-akamai abailly-akamai merged commit d241493 into linode:develop Mar 22, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Placement Groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants