change: [M3-7922] - Clear ACLB configuration certificates if http or tcp protocol is selected
#10311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
jdamore-linode and
abailly-akamai
and removed request for
a team
…tcp` protocol is selected
…http` and `tcp` configutions
|
Coverage Report: ✅ |
bnussman-akamai
requested review from
cliu-akamai
and removed request for
a team
mjac0bs
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
This looked good from my testing with various cert(s) and protocol combinations. The e2e spec that errored passed locally + in CI and I observed the certificates array was cleared for both HTTP and TCP protocol, with successful PUT requests. Left one question about port # for TCP.
✅ HTTP
✅ TCP
packages/validation/.changeset/pr-10311-changed-1711379618292.md
Outdated
Show resolved
Hide resolved
| // If the user has not manually changed the port, and they select HTTPS, | ||
| // set the port to 443 for them. | ||
| if (protocol === 'https') { | ||
| port = 443; |
There was a problem hiding this comment.
Is port 443 fine as a default for TCP protocol?
There was a problem hiding this comment.
When this feature was added, they were okay with no default port for TCP. It will just use whatever was the existing value
abailly-akamai
approved these changes
Mar 25, 2024
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
mjac0bs
added
Approved
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Updates the ACLB configuration to prevent users from running into an API error.
New API validation was added that will throw if you try to send
certificateswith ahttportcpconfiguration. We now need to make sure we don't send certificates if the user selectshttportcpfor their configurationHow to test 🧪
Prerequisites
dev-test-aglbReproduction steps
Certificate table must be empty with configuration protocol "http"Verification steps
As an Author I have considered 🤔