-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8180] - Notification Menu story #10950
Merged
zaenab-akamai
merged 17 commits into
linode:develop
from
zaenab-akamai:M3-8180-notification-menu-story
Oct 3, 2024
Merged
feat: [M3-8180] - Notification Menu story #10950
zaenab-akamai
merged 17 commits into
linode:develop
from
zaenab-akamai:M3-8180-notification-menu-story
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
force-pushed
the
M3-8180-notification-menu-story
branch
from
September 20, 2024 14:09
869cedb
to
16bd8ba
Compare
…kamai/manager into M3-8180-notification-menu-story
zaenab-akamai
changed the title
M3 8180 notification menu story
feat: [M3-8180] - Notification Menu story
Sep 23, 2024
zaenab-akamai
requested review from
carrillo-erik,
cpathipa and
hana-akamai
and removed request for
a team
September 23, 2024 12:45
hana-akamai
approved these changes
Sep 23, 2024
cpathipa
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like BillingActivityPanel.test.tsx is failing can you update the branch with latest from develop.
Coverage Report: ✅ |
carrillo-erik
approved these changes
Sep 24, 2024
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Sep 24, 2024
Cloud Manager E2E Run #6612
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6612
|
Run duration | 27m 07s |
Commit |
ecdf2a9046: feat: [M3-8180] - Notification Menu story (#10950)
|
Committer | zaenab-akamai |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
409
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/clone-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry |
Screenshots
Video
|
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add NotificationMenu Story to Storybook
Changes 🔄
Target release date 🗓️
NA
How to test 🧪
Pull the PR and run
yarn storybook
. Navigate to Notification -> Notification MenuAs an Author I have considered 🤔
Check all that apply