-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8581] - GPUv2 Plan Selection Egress Banner #10956
Conversation
bd4f857
to
a63f76f
Compare
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Banner looks good ✅ Left some non-blocking optional feedback
packages/manager/src/features/components/PlansPanel/PlanInformation.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/components/PlansPanel/PlanInformation.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed GPUv2 banner + the bullet points regarding it
thanks Alban! 🎉
3e7d445
to
3cfd9e3
Compare
Description 📝
Small PR to add a GPUv2 Banner for the 9/30 new GPU plans launch. This is the MVP for the initial launch, before modifying the Plans Panel to account for transfer and billing changes.
Note
This is very much a temp banner, which is the reason for not adding the banner to the existing e2e coverage. It will be removed in an upcoming M2 update.
Changes 🔄
egressBanner
property to theGPUv2
flag objectTarget release date 🗓️
9/30/2024
Preview 📷
How to test 🧪
Important
You may want the
gpuv2beta
flag on your account to get the new GPUv2 plans to show up, but it is not a requirement for testing the display of the bannerVerification steps
gpuv2
flag is onAs an Author I have considered 🤔
Check all that apply