test: [M3-8444] - Add assertions for bucket details drawer tests #10971

AzureLatte · 2024-09-19T16:51:01Z

Description 📝

Add a Cypress integration test to cover OBJ bucket details drawer changes for OBJ Gen 2.

Changes 🔄

Add assertions for bucket details drawer tests
Add new util function mockGetBucketAccess

How to test 🧪

yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts"

As an Author I have considered 🤔

Check all that apply

github-actions · 2024-09-19T17:15:24Z

Coverage Report: ✅
Base Coverage: 86.99%
Current Coverage: 86.99%

mjac0bs

I ran these tests locally on an account that didn't have Object Storage enabled in my Settings, and the tests failed consistently at the point where the 'Enable Object Storage' modal opens after Create Button is clicked. Should this test spec account for that?

Once I enabled OBJ, tests all passed and cover the cases outlined in the internal ticket. ✅

packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts

cpathipa

I think we have three variations for OBJ feature legacy, gen1 and gen2 are we planing to cover those scenarios with mock flags ?

AzureLatte · 2024-09-24T13:58:29Z

I think we have three variations for OBJ feature legacy, gen1 and gen2 are we planing to cover those scenarios with mock flags ?

I checked bucket details drawer by checkBucketDetailsDrawer in all scenarios in this PR.

coliu-akamai · 2024-10-01T19:41:03Z

packages/manager/cypress/support/intercepts/object-storage.ts

+export const mockGetBucketAccess = (
+  label: string,
+  cluster: string
+): Cypress.Chainable<null> => {
+  return cy.intercept(
+    'GET',
+    apiMatcher(`object-storage/buckets/${cluster}/${label}/access`),
+    {
+      body: {},
+      statusCode: 200,
+    }
+  );


Hey @AzureLatte just a heads up that I'd also created a mock intercept for bucket access here. Will keep an eye on this PR, and if this gets merged in first will update my PR accordingly!

mjac0bs · 2024-10-09T16:40:56Z

@AzureLatte This one's got a couple merge conflicts now to be resolved.

coliu-akamai

✅ confirmed tests passed - thanks Azure!

Since this file is named bucket-create, wondering if we should update the name to something like bucket-create-and-details-drawer or something (maybe that's too wordy), or move these assertions to a different file?

coliu-akamai · 2024-10-11T13:15:55Z

packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts

  /**
   * Confirms UI flow for creating a gen2 Object Storage bucket with endpoint E0
   * Confirms all endpoints are displayed regardless if there's multiple of the same type
   * Confirms S3 endpoint hostname displayed to differentiate between identical options in the dropdown
+   * Confirms correct information displays in the details drawer for all endpoint types


Since this test is only for E0, should we specify that? + Same for the below tests

Suggested change

* Confirms correct information displays in the details drawer for all endpoint types

* Confirms correct information displays in the details drawer for a bucket with endpoint E0

Nice suggestion, I'll update it, thank you!

coliu-akamai · 2024-10-11T13:16:17Z

packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts

@@ -320,10 +403,12 @@ describe('Object Storage Gen2 create bucket tests', () => {

  /**
   * Confirms UI flow for creating a gen2 Object Storage bucket with endpoint E2
+   * Confirms correct information displays in the details drawer for all endpoint types


Suggested change

* Confirms correct information displays in the details drawer for all endpoint types

* Confirms correct information displays in the details drawer for a bucket with endpoint E2

coliu-akamai · 2024-10-11T13:16:40Z

packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts

@@ -205,10 +279,12 @@ describe('Object Storage Gen2 create bucket tests', () => {

  /**
   * Confirms UI flow for creating a gen2 Object Storage bucket with endpoint E1
+   * Confirms correct information displays in the details drawer for all endpoint types


Suggested change

* Confirms correct information displays in the details drawer for all endpoint types

* Confirms correct information displays in the details drawer for a bucket with endpoint E1

coliu-akamai · 2024-10-11T13:17:10Z

packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts

@@ -435,10 +525,12 @@ describe('Object Storage Gen2 create bucket tests', () => {

  /**
   * Confirms UI flow for creating a gen2 Object Storage bucket with endpoint E3
+   * Confirms correct information displays in the details drawer for all endpoint types


Suggested change

* Confirms correct information displays in the details drawer for all endpoint types

* Confirms correct information displays in the details drawer for a bucket with endpoint E3

AzureLatte · 2024-10-11T17:00:03Z

e2e failure Linode Create Region Select region select – region select is not related with this change

cypress · 2024-10-11T17:41:32Z

Cloud Manager E2E Run #6663

Run Properties: Failed #6663 • d0927f8c24: test: [M3-8444] - Add assertions for bucket details drawer tests (#10971)

Project	`Cloud Manager E2E`
Run status	`Failed #6663`
Run duration	`29m 15s`
Commit	`d0927f8c24: test: [M3-8444] - Add assertions for bucket details drawer tests (#10971)`
Committer	`Azure-akamai`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`434`

Tests for review

cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts • 1 failed test

View Output Video

Test		Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry		`Screenshots` `Video`

linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
clone linode > can clone a Linode from Linode details page		`Screenshots` `Video`

linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
rebuild linode > cannot rebuild a provisioning linode		`Screenshots` `Video`

objectStorageGen2/bucket-create-gen2.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Object Storage Gen2 create bucket tests > can create a bucket with E2 endpoint type		`Screenshots` `Video`

Add assertions for bucket details drawer tests

12f1ff0

AzureLatte self-assigned this Sep 19, 2024

AzureLatte requested a review from a team as a code owner September 19, 2024 16:51

AzureLatte requested review from jdamore-linode and removed request for a team September 19, 2024 16:51

Added changeset: Add assertions for bucket details drawer tests

8c9535f

AzureLatte requested a review from a team as a code owner September 19, 2024 16:51

AzureLatte requested review from mjac0bs and cpathipa and removed request for a team September 19, 2024 16:51

AzureLatte added the Ready for Review label Sep 19, 2024

mjac0bs reviewed Sep 20, 2024

View reviewed changes

packages/manager/cypress/e2e/core/objectStorageGen2/bucket-create-gen2.spec.ts Show resolved Hide resolved

mjac0bs added the Object Storage Gen2 label Sep 20, 2024

cpathipa reviewed Sep 23, 2024

View reviewed changes

Add one more assertion to check toggle is not visible for E2,E3

dd3684d

Merge branch 'develop' into M3-8444

0cf861f

coliu-akamai reviewed Oct 1, 2024

View reviewed changes

AzureLatte requested review from mjac0bs, coliu-akamai and cpathipa October 8, 2024 18:50

resolve conflicts

6134281

coliu-akamai approved these changes Oct 11, 2024

View reviewed changes

update comments

4f22b82

mjac0bs approved these changes Oct 11, 2024

View reviewed changes

mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Oct 11, 2024

AzureLatte merged commit d0927f8 into linode:develop Oct 11, 2024
21 of 23 checks passed

AzureLatte deleted the M3-8444 branch October 11, 2024 17:10

This was referenced Oct 23, 2024

Release v1.131.0 - release → staging #11153

Merged

Release v1.131.0 - staging → master #11175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [M3-8444] - Add assertions for bucket details drawer tests #10971

test: [M3-8444] - Add assertions for bucket details drawer tests #10971

AzureLatte commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

mjac0bs left a comment

cpathipa left a comment

AzureLatte commented Sep 24, 2024

coliu-akamai Oct 1, 2024

mjac0bs commented Oct 9, 2024

coliu-akamai left a comment

coliu-akamai Oct 11, 2024

AzureLatte Oct 11, 2024

coliu-akamai Oct 11, 2024

coliu-akamai Oct 11, 2024

coliu-akamai Oct 11, 2024

AzureLatte commented Oct 11, 2024

cypress bot commented Oct 11, 2024

	* Confirms correct information displays in the details drawer for all endpoint types
	* Confirms correct information displays in the details drawer for a bucket with endpoint E0

test: [M3-8444] - Add assertions for bucket details drawer tests #10971

test: [M3-8444] - Add assertions for bucket details drawer tests #10971

Conversation

AzureLatte commented Sep 19, 2024 • edited Loading

Description 📝

Changes 🔄

How to test 🧪

As an Author I have considered 🤔

github-actions bot commented Sep 19, 2024 • edited Loading

mjac0bs left a comment

Choose a reason for hiding this comment

cpathipa left a comment

Choose a reason for hiding this comment

AzureLatte commented Sep 24, 2024

coliu-akamai Oct 1, 2024

Choose a reason for hiding this comment

mjac0bs commented Oct 9, 2024

coliu-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai Oct 11, 2024

Choose a reason for hiding this comment

AzureLatte Oct 11, 2024

Choose a reason for hiding this comment

coliu-akamai Oct 11, 2024

Choose a reason for hiding this comment

coliu-akamai Oct 11, 2024

Choose a reason for hiding this comment

coliu-akamai Oct 11, 2024

Choose a reason for hiding this comment

AzureLatte commented Oct 11, 2024

cypress bot commented Oct 11, 2024

Cloud Manager E2E Run #6663

Tests for review

AzureLatte commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading