Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8446] - Add cypress test for Object Storage gen 2 Access Keys landing page #10984

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

coliu-akamai
Copy link
Contributor

Description 📝

  • Adds integration test using mock data to confirm Access Keys landing page flow

Changes 🔄

  • add cypress test and mock intercept
  • updated a styled component to remove dom warning

Target release date 🗓️

9/30+

How to test 🧪

  • yarn cy:run -s "cypress/e2e/core/objectStorageGen2/bucket-access-keys.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Sep 23, 2024
@coliu-akamai coliu-akamai marked this pull request as ready for review September 23, 2024 13:37
@coliu-akamai coliu-akamai requested review from a team as code owners September 23, 2024 13:37
@coliu-akamai coliu-akamai requested review from jdamore-linode, hana-linode and hkhalil-akamai and removed request for a team September 23, 2024 13:37
Copy link

github-actions bot commented Sep 23, 2024

Coverage Report:
Base Coverage: 87.13%
Current Coverage: 87.13%

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally!

@@ -9,7 +9,7 @@ interface StyledLastColumnCellProps extends TableCellProps {
addPaddingRight?: boolean;
}
export const StyledLastColumnCell = styled(TableCell, {
shouldForwardProp: omittedProps(['isObjMultiClusterEnabled']),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants