change: [M3-8415] - Hide SMTP warning for Linodes and accounts that have SMTP enabled #10991
Conversation
hkhalil-akamai
requested review from
bnussman-akamai and
hana-akamai
and removed request for
a team
|
Coverage Report: ✅ |
| // "In an effort to fight spam, Linode restricts outbound connections on ports 25, 465, and 587 on all Linodes for new accounts created after November 5th, 2019." | ||
| // https://www.linode.com/docs/email/best-practices/running-a-mail-server/ | ||
| export const MAGIC_DATE_THAT_EMAIL_RESTRICTIONS_WERE_IMPLEMENTED = | ||
| '2022-11-30T00:00:00.000Z'; // Date of release for Manager v1.81.0. | ||
|
|
There was a problem hiding this comment.
Since we are directly using the SMTP status of accounts/Linodes, we no longer need this magic date.
hkhalil-akamai
requested review from
AzureLatte
and removed request for
a team,
mjac0bs and
AzureLatte
There was a problem hiding this comment.
Thanks for taking this on, Hussain! Exciting to move away from the magic constant and have backend support for this.
This looks good in dev. From what I can tell based on the API PRs merge dates, this has not yet been release to prod yet. Can we update the testing instructions to specify testing in the dev environment?
| const { data: account } = useAccount(); | ||
|
|
||
| const displayRestrictionText = |
There was a problem hiding this comment.
More of a backend question: Do we know if it's possible for an account to have SMTP_ENABLED, but an individual Linode is still disabled (with net exceptions on its ports)? If that state were possible, we're currently showing the notice for the Linode, which seems like what we'd want for transparency... unless, somehow, the individual net exceptions don't always get removed when SMTP_ENABLED is added account-wide, which could be confusing for customers.
There was a problem hiding this comment.
Do we know if it's possible for an account to have SMTP_ENABLED, but an individual Linode is still disabled
Yes, it's possible.
I was surprised to learn that there is no logic in the API that links the customer tag with the Net Filter Exceptions of a particular Linode. Adding the tag is a manual process used by support representatives when a customer requests SMTP abilities on their Linode and it is only used to keep track of which customers have had this request granted.
The availability of SMTP for a Linode is determined solely by the presence (or lack thereof) of the SMTP Net Filter Exceptions. There is also a field on the customer called 'Default Net Filter Exceptions' that is applied by default to new Linodes.
So the choice to only use the capability from the Linode object was intentional, since that is the source of truth of whether a particular Linode is SMTP-capable.
For a detailed summary of this topic, I suggest the KB article SMTP Port Restrictions.
There was a problem hiding this comment.
Adding the tag is a manual process used by support representatives when a customer requests SMTP abilities on their Linode and it is only used to keep track of which customers have had this request granted.
Super helpful context and surprises me also.
So the choice to only use the capability from the Linode object was intentional, since that is the source of truth of whether a particular Linode is SMTP-capable.
Got it; agree with this.
| const { data: account } = useAccount(); | ||
|
|
||
| const displayRestrictionText = |
There was a problem hiding this comment.
Adding the tag is a manual process used by support representatives when a customer requests SMTP abilities on their Linode and it is only used to keep track of which customers have had this request granted.
Super helpful context and surprises me also.
So the choice to only use the capability from the Linode object was intentional, since that is the source of truth of whether a particular Linode is SMTP-capable.
Got it; agree with this.
bnussman-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Run status |
|
| Run duration | 27m 01s |
| Commit |
|
| Committer | Hussain Khalil |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
429
|
…ave SMTP enabled (linode#10991) * Hide SMTP warning for Linodes and accounts that have SMTP enabled * Update unit tests * Added changeset: Hide SMTP warning for Linodes and accounts that have SMTP enabled * Added changeset: 'SMTP Enabled' account & Linode capabilities * Remove magic date
Description 📝
Leverages the new
"SMTP Enabled"account & Linode capabilities to hide the SMTP warning when it doesn't apply.The SMTP warning appears in two places:
"SMTP Enabled"account capability."SMTP Enabled"Linode capability is present on the selected Linode.How to test 🧪
Prerequisites
Use the alpha API environment.
You will need an account with at least one Linode.
In Admin: remove the
SMTP_ENABLEDcustomer tag from the account or ensure that it's not present. For the test Linode, check that the Net Filter Exceptions field appears as below or change it to match:Testing steps
SMTP_ENABLEDcustomer tag to your accountAs an Author I have considered 🤔
Check all that apply