Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [UIE-8150] - DBaaS empty landing page show logo for V2 #10993

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: [UIE-8150] - DBaaS empty landing page show logo for V2 #10993

merged 1 commit into from
Sep 25, 2024

Conversation

corya-akamai
Copy link
Contributor

@corya-akamai corya-akamai commented Sep 24, 2024 •
edited
Loading

Description 📝

DBaaS empty landing page show logo for V2

Changes 🔄

  • Use feature flag and account capability to show V2 logo

Target release date 🗓️

9/39/24

How to test 🧪

Prerequisites

  • Managed Databases account capability
  • Not in V2

Reproduction steps

  • Go to empty landing page

Verification steps

  • No logo for V2 user

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • [] 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner September 24, 2024 14:48
@corya-akamai corya-akamai requested review from dwiley-akamai and abailly-akamai and removed request for a team September 24, 2024 14:48
@bnussman-akamai bnussman-akamai added DBaaS Relates to Database as a Service Add'tl Approval Needed Waiting on another approval! labels Sep 24, 2024
@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 87.13%
Current Coverage: 87.13%

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 24, 2024
@jcallahan-akamai jcallahan-akamai removed the request for review from dwiley-akamai September 24, 2024 18:01
@abailly-akamai abailly-akamai merged commit 51ff822 into linode:develop Sep 25, 2024
19 of 20 checks passed
This was referenced Sep 25, 2024
Merged
Merged
@corya-akamai corya-akamai deleted the UIE-8150-dbaas-empty-landing branch September 26, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

Assignees

@corya-akamai corya-akamai

Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corya-akamai @bnussman-akamai @abailly-akamai